[Pkg-iscsi-maintainers] Bug#732793: open-iscsi: Incorect service unit for umountiscsi.sh when using systemd

[Gilles Mocellin]

Package: open-iscsi
Version: 2.0.873+git0.3b4b4500-1
Severity: normal

Dear Maintainer,

Here on Debian sid (open-iscsi 2.0.873+git0.3b4b4500-1 and systemd 204-5),
I see that error in the logs when stopping open-iscsi :

déc. 21 19:22:08 guitare systemd[1]: Stopping LSB: Starts and stops the
iSCSI initiator services and logs in to default targets...
déc. 21 19:22:08 guitare open-iscsi[32469]: Failed to issue method call:
Unit umountiscsi.sh.service not loaded.
déc. 21 19:22:08 guitare open-iscsi[32469]: invoke-rc.d: initscript
umountiscsi.sh, action "stop" failed.
déc. 21 19:22:08 guitare open-iscsi[32469]: Couldn't unmount all iSCSI
devices. Cannot stop iSCSI service ... failed!
déc. 21 19:22:08 guitare systemd[1]: open-iscsi.service: control process
exited, code=exited status=1
déc. 21 19:22:08 guitare systemd[1]: Stopped LSB: Starts and stops the
iSCSI initiator services and logs in to default targets.
déc. 21 19:22:08 guitare systemd[1]: Unit open-iscsi.service entered
failed state.

The /etc/init.d/open-iscsi script tries to stop
/etc/init.d/umountiscsi.sh via invoke-rc.d.

But, using systemd, invoke-rc.d passes throught
/lib/lsb/init-functions.d/40-systemd
which construct a systemd service file from init script name, removing
".sh" to scripts that have that extension, like umountiscsi.sh.

Debugging invoke-rc.d, I see it :
sh -x /usr/sbin/invoke-rc.d umountiscsi.sh stop
...
...
+ systemctl stop umountiscsi.sh.service
Failed to issue method call: Unit umountiscsi.sh.service not loaded.
+ RC=5
+ test ! -z 
+ test ! -z 
+ printerror initscript umountiscsi.sh, action "stop" failed.
+ test x = x
+ basename /usr/sbin/invoke-rc.d
+ echo invoke-rc.d: initscript umountiscsi.sh, action "stop" failed.
invoke-rc.d: initscript umountiscsi.sh, action "stop" failed.
+ exit 5

It tries to stop a systemd unit called umountiscsi.sh.service, and
there's only one called umountiscsi.service, thanks to
/lib/lsb/init-functions.d/40-systemd.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (101, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-2-amd64 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages open-iscsi depends on:
ii  libc6  2.17-97
ii  udev   204-5

open-iscsi recommends no packages.

open-iscsi suggests no packages.

-- Configuration Files:
/etc/iscsi/initiatorname.iscsi [Errno 13] Permission non accordée: u'/etc/iscsi/initiatorname.iscsi'

-- no debconf information