[Pkg-iscsi-maintainers] Bug#710148: open-iscsi: Added autopkgtests
Ritesh Raj Sarraf
rrs at researchut.com
Wed May 29 09:34:50 UTC 2013
On Tuesday 28 May 2013 09:28 PM, Yolanda Robla wrote:
> + testlib.cmd(['iscsiadm', '-m', 'node', '--targetname', initiatorname, '-p', '%s:3260' % remote_server, '--op=update', '--name', 'node.startup', '--value=manual'])
> + testlib.cmd(['iscsiadm', '-m', 'node', '--targetname', initiatorname, '-p', '%s:3260' % remote_server, '--op=update', '--name', 'node.conn[0].startup', '--value=manual'])
What'll happen if you iscsi db has multiple connection portals? Here you
are taking care of conn[0] only.
> + testlib.cmd(['iscsiadm', '-m', 'node', '--targetname', initiatorname, '-p', '%s:3260' % remote_server, '--logout'])
> +
Why don't you decouple the port also? I see no value in you hardcoding
the port here.
> +if __name__ == '__main__':
> + import optparse
> + parser = optparse.OptionParser()
Please port it to argparse. optparse is deprecated since Python 2.7.
--
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 897 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20130529/3a88b032/attachment.pgp>
More information about the Pkg-iscsi-maintainers
mailing list