[Pkg-iscsi-maintainers] [open-iscsi] 21/33: iscsiadm: Check for mode is not required when creating params list

Ritesh Raj Sarraf rrs at alioth.debian.org
Tue Nov 5 16:21:16 UTC 2013


This is an automated email from the git hooks/post-receive script.

rrs pushed a commit to branch upstream-mnc
in repository open-iscsi.

commit ff4b2c1eb0058ed5e20aaddf7039d57715cebd57
Author: Adheer Chandravanshi <adheer.chandravanshi at qlogic.com>
Date:   Thu May 9 13:57:49 2013 +0530

    iscsiadm: Check for mode is not required when creating params list
    
    There is no need to explicitly check for mode while creating the params
    list of name/value pairs.
    
    Reported-by: Leeman Duncan <leeman.duncan at gmail.com>
    Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi at qlogic.com>
---
 usr/iscsiadm.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/usr/iscsiadm.c b/usr/iscsiadm.c
index efe6383..84d5a27 100644
--- a/usr/iscsiadm.c
+++ b/usr/iscsiadm.c
@@ -2962,9 +2962,7 @@ main(int argc, char **argv)
 			usage(0);
 		}
 
-		if ((mode == MODE_IFACE ||
-		     (mode == MODE_HOST && sub_mode == MODE_FLASHNODE)) &&
-		    name && value) {
+		if (name && value) {
 			param = idbm_alloc_user_param(name, value);
 			if (!param) {
 				log_error("Cannot allocate memory for params.");

-- 
Alioth's /usr/local/bin/git-commit-notice on /srv/git.debian.org/git/pkg-iscsi/open-iscsi.git



More information about the Pkg-iscsi-maintainers mailing list