[Pkg-iscsi-maintainers] Bug#717155: iscsitarget-dkms: Fails to build against Linux 3.10

[Moritz Muehlenhoff]

On Tue, Aug 27, 2013 at 12:53:08PM +0530, Ritesh Raj Sarraf wrote:
> On Monday 26 August 2013 11:34 PM, Michael Papet wrote:
> > As of 3.10-2-686-pae in Jessie this is still open
> >
> > Using dpkg-reconfigure, the following is the log:
> >
> > DKMS make.log for iscsitarget-1.4.20.3+svn490 for kernel
> > 3.10-2-686-pae (i686)
> > Mon Aug 26 10:58:30 PDT 2013
> > make: Entering directory `/usr/src/linux-headers-3.10-2-686-pae'
> >   LD      /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/built-in.o
> >   LD     
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/built-in.o
> >   CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/tio.o
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/tio.c: In
> > function âtio_add_dataâ:
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/tio.c:75:25:
> > warning: comparison of distinct pointer types lacks a cast [enabled by
> > default]
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/tio.c:82:18:
> > warning: comparison of distinct pointer types lacks a cast [enabled by
> > default]
> >   CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/iscsi.o
> >   CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/nthread.o
> >   CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/wthread.o
> >   CC [M]  /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.o
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.c: In
> > function âiet_procfs_exitâ:
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.c:37:32:
> > error: dereferencing pointer to incomplete type
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.c:37:52:
> > error: dereferencing pointer to incomplete type
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.c: In
> > function âiet_procfs_initâ:
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.c:49:3:
> > error: implicit declaration of function âcreate_proc_entryâ
> > [-Werror=implicit-function-declaration]
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.c:49:7:
> > warning: assignment makes pointer from integer without a cast [enabled
> > by default]
> > /var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.c:51:7:
> > error: dereferencing pointer to incomplete type
> > cc1: some warnings being treated as errors
> > make[4]: ***
> > [/var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel/config.o] Error 1
> > make[3]: *** [/var/lib/dkms/iscsitarget/1.4.20.3+svn490/build/kernel]
> > Error 2
> > make[2]: *** [_module_/var/lib/dkms/iscsitarget/1.4.20.3+svn490/build]
> > Error 2
> > make[1]: *** [sub-make] Error 2
> > make: *** [all] Error 2
> > make: Leaving directory `/usr/src/linux-headers-3.10-2-686-pae'
> >
> This seems to have been happening lately because all warnings are
> treated as failures for Jessie. I have other packages too that are
> failing. I haven't had time to look into this, but the fix would be to
> export CFLAGS variable, adding the warning flags there, or else fix
> every gcc warning..

No, that's related to changes in Linux 3.10:

See https://lwn.net/Articles/549737/

| create_proc_entry()/create_proc_read_entry() are killed off; use proc_create().

This has already been fixed in upstream trunk:
http://sourceforge.net/p/iscsitarget/code/496/

You could pull the fix for the sid package.

Cheers,
        Moritz