[Pkg-iscsi-maintainers] Bug#756843: open-iscsi: 7e1ae42 patch only mounting first target disk, then always failing in the end even on success

[Turbo Fredriksson]

On Aug 3, 2014, at 2:38 PM, Ritesh Raj Sarraf wrote:

> Why ?? It should work. Your previous bug report was about swap devices
> not being handled. With its inclusion, why will it not work ?


1. Because there's no fsck before mounting the filesystem.

   That's really ugly, and potentially dangerous. Yes, it will simply fail if the fs
   is dirty, but I'm sure there's occasions where mount doesn't discover everything
   and a fsck should have been done first. Also, it's just common practice...

2. There's no '-O _netdev' to swapon. There is for mount, so the 

	mount -a

   in your new version should then be written as

	mount -a -O _netdev

   similar to what's done in umountiscsi.sh, so that's part ok. But it's still
   the matter of not fsck'ing the filesystem before mount.

3. A 'mount -a' (or even 'mount -a -O _netdev') will/might include unwanted 
   filesystem. Currently the code will skip filesystems of the type

	nfs|nfs4|smbfs|cifs|coda|ncp|ncpfs|ocfs2|gfs|ceph

4. No other init script (that I've seen) simply "mounts everything". All scripts
   have some control over what's mounted and what's not (including swapon).



Doing some tests, this seems to be ok:

	fsck -a -M -T -s
        mount -a -O _netdev
        swapon -a

I'm not sure I like the 'do on everything' part though..
--
Michael Jackson is not going to buried or cremated
but recycled into shopping bags so he can remain white,
plastic and dangerous for kids to play with.