[Pkg-iscsi-maintainers] Bug#758532: open-iscsi: remove erronous failed message

[Ritesh Raj Sarraf]

The bug I was talking about is:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756843

I have pretty much concluded it in there. Hence, in my next upload, I'll be
dropping that section of the code.


On Mon, Aug 18, 2014 at 11:46 PM, Ritesh Raj Sarraf <rrs at researchut.com>
wrote:

> I think there is another bug report, from which I've concluded to drop off
> this section of the code because it has too many erroneous behavior.
>
> When I have access to the laptop, I'll attach that bug report
>
> s3nt fr0m a $martph0ne, excuse typ0s
> On Aug 18, 2014 8:51 PM, "Powers, Joshua" <joshua.powers at hp.com> wrote:
>
>> Package: open-iscsi
>> Version: 2.0.873+git0.3b4b4500-2
>> Severity: wishlist
>> Tags: patch
>>
>> When open-iscsi is installed, but does not have anything configured the
>> user will see an unnecessary error message:
>> "[FAIL] Mounting network filesystems: failed!"
>>
>> The patch below removes this message by determining if we ever attempted
>> to mount something. If we did not then the message will no longer appear.
>>
>> Thanks for considering the patch,
>> Josh
>>
>> --- debian/open-iscsi.init    2014-08-11 14:37:43.784410000 +0000
>> +++ debian/open-iscsi.init    2014-08-11 14:38:47.388410000 +0000
>> @@ -126,6 +126,7 @@
>>         # Now let's mount
>>         log_daemon_msg "Mounting network filesystems"
>>         MOUNT_RESULT=1
>> +       MOUNT_ATTEMPT=0
>>         fs=
>>         grep -w _netdev /etc/fstab | \
>>             while read DEV MTPT FSTYPE OPTS REST; do
>> @@ -150,6 +151,7 @@
>>             done | \
>>             while read fs; do
>>                 set -- $(eval echo "$fs" | sed 's@:@ @')
>> +               MOUNT_ATTEMPT=1
>>                 case "$1" in
>>                     swap)
>>                         swapon $2
>> @@ -168,7 +170,7 @@
>>
>>
>>
>> -       log_end_msg $MOUNT_RESULT
>> +       log_end_msg $((MOUNT_RESULT * MOUNT_ATTEMPT))
>>  }
>>
>>  starttargets() {
>>
>>


-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20140819/299638c3/attachment.html>