[Pkg-iscsi-maintainers] Bug#809334: Bug#809320: open-iscsi: no session termination on stop

[Christian Seiler]

Hi Ritesh,

On 12/30/2015 10:56 AM, Ritesh Raj Sarraf wrote:
>> So one solution could be to use SuccessExitStatus=0 15 in the unit to
>> say that 'already logged in' is not an error condition (and possibly
>> others, I'd have to check the manpage) - but I think that is
>> short-sighted, as this will prevent systemd from thinking the service
>> is active and thus not terminate any active sessions (including
>> manually activated ones) on shutdown.
>>
>> Therefore, I think the correct solution is to simply ignore errors
>> from the iscsiadm call in the open-iscsi.service file,
>>
> 
> You mean ignore errors of all types ?
> What if one of the session couldn't be established because the target's
> respective interface had a failure ?

Well, that would not be ideal, obviously. But if we propagate the
error and just ignore 15 (already logged in) then we'll have the
case that some portals will be in the logged-in state and others
might not; and if systemd thinks the service didn't successfully
start, it will not logout of sessions on shutdown. This is obviously
not optimal, but because of the follow-up errors there still will be
some user feedback, so I think that is the simplest solution.

I have a more complicated idea of how to solve this in a better way,
but it also touches a *lot* of corner cases and as I said I don't
have time right now to work on and especially that - but if you can
wait a bit, I'll take a look in three weeks (please ping me after
Jan 16th in case I forget :-)).

Regards,
Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20151230/eb63c14e/attachment.sig>