[Pkg-iscsi-maintainers] Bug#775778: Bug#776276: unblock: open-iscsi/2.0.873+git0.3b4b4500-4

[Michael Biebl]

Am 27.01.2015 um 13:07 schrieb Christian Seiler:
> Am 27.01.2015 um 06:19 schrieb Michael Biebl:
>>> Of course, if you have a better idea of how to do this?
>>
>> Aside from shipping real native unit files, that's probably the least
>> invasive change:
>>
>> - Drop $remote_fs from the open-isci LSB header and replace it with
>> $local_fs. That looks wrong anyway.
> 
> As I said before: that breaks sysvinit systems with /usr on NFS.

How likely is such a setup? I.e. using /usr-on-NFS + openisci in
combination. Has anyone actually ever tested this?

> There's even an old bug report on that:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=541390

This was not an actual breakage whic was reported. But rather some
mechanical check for binary in /usr -> $remote_fs. If that was a good
idea is questionable, i.e. making basically every service depend on
$network, when in 99,9% of all cases they don't actually need it.

> [Service]
> # Replace stop actions, because calling umountiscsi.sh from
> # within open-iscsi script won't work due to systemctl
> # redirection (and umountiscsi.sh is never started)
> # Note that we have to test for /etc/iscsi/iscsi.initramfs,
> # since the init script also does this test. Use exec to
> # make sure that umountiscsi.sh's PPID is 1, so we don't run
> # into the redirect ourselves.
> ExecStop=
> ExecStop=/bin/sh -c "[ -f /etc/iscsi/iscsi.initramfs ] || exec
> /etc/init.d/umountiscsi.sh stop"
> ExecStop=/etc/init.d/open-iscsi stop

Why is this check needed? After all, on shutdown we do call
"/etc/init.d/umountiscsi.sh stop" before "/etc/init.d/open-iscsi stop".
I.e. wouldn't this break the shutdown case, assuming there is an
/etc/iscsi/iscsi.initramfs file?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20150127/1052ab0b/attachment.sig>