[Pkg-iscsi-maintainers] Bug#804591: Bug#804591: open-iscsi: iscsi_auto flag should use iscsistart --fwparam_network in addition to -b

[Christian Seiler]

Control: tags -1 + confirmed
Control: found -1 2.0.873-3
Control: notfound -1 2.0.873-3ubuntu13

On 11/09/2015 08:39 PM, Scott Moser wrote:
> It seems that 'iscsi_auto' should invoke 'iscsistart --fwparam_network' in
> addition to -b.
> The --fwparam_network will set up networking that was declared in iBFT.
> 
> There is some overlap here with the 'ip=' kernel command line parameter,
> and it is possible that the two could conflict.  For example, if the
> kernel command line had 
>    ip=192.168.1.2::192.168.1.1:255.255.255.0:myhostname:eth0
> 
> And iBFT was configured such that
>    $ cat /sys/firmware/ibft/ethernet0/ip-addr
>    192.168.1.3
>    $ cat /sys/firmware/ibft/ethernet0/gateway
>    192.168.1.1
>    $ cat /sys/firmware/ibft/ethernet0/subnet-mask
>    255.255.255.0
> 
> If we were to invoke 'iscsistart --fwparam_network' after having done
> configure_networking, then the iscsi parameters would be in affect.
> Its may be arguable that this is simply misconfiguration of the ip=
> parameter.

On the other hand, one could argue that one might want to overwrite
the parameters set in the firmware with an explicit kernel commmand
line.

I think the case is definitely clear if iscsi_auto is specified
without an ip= parameter, then iscsistart should take care of it.

Btw. is there any way to test this in a VM? I don't have access to
the corresponding hardware that sets these values, so I can't
really test this myself.

> Also of note, /run/net-<device>.conf will not be written if iscsistart
> configures the networking as opposed to 'ipconfig' doing it.

Could you give me the output of

iscsistart -f

on a system with iBFT? I think I could write a trivial POSIX
shell parser for that that creates the corresponding
/run/net-*.conf files. From the open-iscsi source I'm pretty
confident I know what the output looks like, but I'd rather
have real data to test that with.

Regards,
Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20151109/d6a5a41e/attachment.sig>