[Pkg-iscsi-maintainers] Bug#835537: jessie-pu: package open-iscsi/2.0.873+git0.3b4b4500-8+deb8u1

[Christian Seiler]

Package: release.debian.org
User: release.debian.org at packages.debian.org
Usertags: pu
Tags: jessie
Severity: normal
X-Debbugs-Cc: pkg-iscsi-maintainers at lists.alioth.debian.org, kibi at debian.org

Dear release team,
(Cc'ing KiBi because this affects d-i/udebs.)

I'd like to propose an update of open-iscsi for the next point release.
It fixes the following two bugs:

 - https://bugs.debian.org/834830 (Severity: serious)

   This was reported on debian-user recently: after an installation on
   an iSCSI device, open-iscsi-udeb contains a hook to copy /etc/iscsi
   from the d-i environment over to the system. But it doesn't
   regenerate the initramfs afterwards - and because the daemon was
   never started in the installed system, the initiatorname.iscsi file
   would not contain a valid initiator name.

   Basically, this rendered a freshly installed system on iSCSI
   unbootable.

   sid hasn't been affected for a while, since we moved the generation
   logic from daemon startup to postinst. However, that change is not
   trivial, and the simpler fix is to simply regenerate the initramfs
   after copying the configuration to the system. In order to not have
   code in Jessie that's not also in sid, I've added the initramfs
   regeneration to the package in sid anyway. [1] (Even though it's not
   necessary there.)

   I've tested the udeb by starting an 8.5 installer, and installing
   the updated udeb via wget + udpkg and can confirm that it now works
   as expected.

 - https://bugs.debian.org/833917 (Severity: important)

   This was also reported on debian-user recently. There's a race
   condition at startup: while the current init script of open-iscsi
   does wait for the iSCSI disks themselves to appear via udevadm
   settle, the kernel scans disks for partitions asynchronously,
   which can lead to LVs on partitions not being activated.

   The proper fix for that will be to switch to an event-based startup;
   in order to support that in combination with LVM one needs lvmetad
   though - which doesn't work in Jessie. (See #774082.)

   The simplest workaround is to just wait a second after iSCSI session
   login. This is not ideal, but the least-invasive fix to improve the
   experience for Jessie users. I've also applied this workaround to
   the package in sid [2], because the event-based logic isn't complete
   there yet.

   In sid we already had a similar workaround when multipath was
   installed, waiting 3s. (multipath is even more racy.) I've taken the
   liberty in backporting that fix to Jessie as well.

   I've tested the resulting package on a Jessie system.

Source debdiff against the current version in Jessie is attached.

Thanks for considering,
Christian

[1] http://sources.debian.net/src/open-iscsi/2.0.873%2Bgit1.4c1f2d90-2/debian/open-iscsi-udeb.finish-install/#L15
[2] http://sources.debian.net/src/open-iscsi/2.0.873%2Bgit1.4c1f2d90-2/debian/extra/activate-storage.sh/#L58

-------------- next part --------------
A non-text attachment was scrubbed...
Name: pu-open-iscsi.diff
Type: text/x-patch
Size: 2546 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20160826/bb3d96f3/attachment-0001.bin>