[Pkg-iscsi-maintainers] [RFC] open-isns packaging, please review

[Christian Seiler]

Dear Ritesh,

I've now packaged open-isns for Debian, and it would be great if you
could review the package. I've pushed it to git on alioth, within the
pkg-iscsi group:

https://anonscm.debian.org/cgit/pkg-iscsi/open-isns.git/

Clone:

git clone https://anonscm.debian.org/git/pkg-iscsi/open-isns.git/

Main features of the packaging:

 - proper DEP-5 debian/copyright
 - dh(1) style debian/rules
 - debhelper 10 compat (lintian has a false positive here btw., to
   use compat 10, you need to have debhelper >= 9.20160403~ in your
   B-D's, not >= 10, as that doesn't exist yet)
 - libisns0 (shared library pkg) + libisns-dev are proper Multi-Arch
 - proper symbols file for libisns.so.0
 - autopkgtest integration tests to see if the iSNS server and the
   discovery daemon do start up
 - debconf prompts for the discovery daemon (which only starts if an
   iSNS server is available), translatable via po-debconf (but not
   translated yet)
 - proper watch file (uscan works)
 - full hardening enabled
 - libisns.so.0 installed in /lib not /usr/lib, because open-iscsi
   is in / and not in /usr
 - udeb for libisns.so.0, so that later open-iscsi-udeb can depend
   on that
 - proper git packaging (gbp.conf, pristine-tar, etc.)
 - open-iscsi git master builds against it (but I haven't tried to
   update the Debian package yet)
 - service files for systemd + init scripts for sysvinit (both
   tested)

Note that up until recently open-isns couldn't build a shared library,
I've actually first worked with upstream to get a lot of generic stuff
fixed there, before packaging this for Debian. (Upstream is very
responsive btw.) The diff between the versions 0.95 and 0.96 is mostly
things I sent as github pull requests.

Upstream's documentation is a bit sparse, I have to admit, so unless
you know what you're doing, it's not so easy to play around with it.
Feel free to ask me if you have further questions.

It would be great if you could review my packaging work, I would
appreciate some feedback.

Regards,
Christian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-iscsi-maintainers/attachments/20160620/529f5740/attachment.sig>