[Pkg-jed-commit] r295 - in trunk/packages/jed-extra/debian: . init patches

[G. Milde]

On 22.05.06, Jörg Sommer wrote:

> Log:
> * control:
...
>   + dropped jed and xjed from the build dependencies; they are no longer
>     needed


> * patches/grep.dpatch, patches/rst.dpatch, patches/make_ini.dpatch:
>   + these modes are buggy; hopefully upstream fixes this before release :)

If I remember right, Debian Policy (or the Maintainer Guide) strongly
suggest cooperation with the upstream autor for fixing bugs upstream
whenever possible. 

IMO, dpatches should be a last resort

  * if there is no response from the author in a reasonable time
  * if the proposed fix by the author violates Debian Policy or doesnot
    fit into the system in some other way
  * in certain cases, if author and maintainer disagree about the
    "bugginess" of the code (i.e. the author is not willing to fix but
    the problem is critical in a Debian system).
  * If the problem is Debian specific and author and maintainer agreed to
    fix it just in the Debian package.
    
IMO, a dpatch is certainly not needed to suppress a non-critical warning.    


I am happy to receive bug reports, more to receive patches (with
explanation) but very unhappy with dpatches to my modes in a package I
maintain - without explanation about the bug they intend to fix.

 
> * patches/00list:
...
>   + activated the patches for yodl and rfcview, because they are included
>     in the package even if as experimental modes

the rfcview patch is also modified. I cannot easily parse the diff of a
diff, but did you test whether the patched patch actually works?
 
> * jed-extra-preparse.sl:
>   + there was a white space to much, which caused jed did not find the
>     files in /usr/share/jed/lib/

sorry for this, it must have slipped in accidentially while
viewing/editing another part.
 
> * renamed jed-extra.install.template as install
> 
> * contents.txt:
>   + disabled all lines with modes not found in upstream archive -- should
>     we remove these lines?

Please only remove lines with modes not found in jedmodes.sf.net/mode/
(There are modes listed at Jedmodes with the sources outside the CVS
archive.)

> * sort-modes.sl:
>   + removed; its not needed anymore
>
> * rules:
>   + all the stuff that was done in sort-mode.sl implemented directly in
>     make with shell tools. This saves uses the dependency on jed

Actually, I would prefer to keep the sorting in SLang. It is IMO easier
to comprehend and maintain than a bunch of make|sed|sh rules.

As jed-extra is of no use without jed anyway, the dependency doesnot pose
a serious restriction.

>   + dropped the dependency from the get-orig-source target; mistake in
>     the last commit

The idea is that the orig-source will only be fetched, if it is not
already in place.

Please remove it if you want a fresh version, maybe with a rule like
get-fresh-orig-source.

I have to test the package also on a non-connected machine.

>   + dropped the chmod for apsmode; its not needed anymore

Are you sure? The Jedmodes CVS has these files in executable mode and
every update will put them into this mode again.

Günter

-- 
Milde ife.et.tu-dresden.de