[Pkg-jed-commit] r295 - in trunk/packages/jed-extra/debian: . init patches

[Jörg Sommer]

Hallo G.,

G. Milde schrieb am Fri 26. May, 13:53 (+0200):
> On 24.05.06, Jörg Sommer wrote:
>  
> > The source includes CVS conflict marks. That's more than an error. 
> 
> Indeed. That is a sign of something more strange going that definitely
> requires a fix upstream... (it was the result of several CVS failures
> at Sourceforge lately).

How can this happen with cvs export?

> > And yes, I would do code cleanup like warnings, because they
> > are an indicator of pitfalls.
> 
> But please not in a dpatch.

Where else? This is the right way to apply changes to the upstream
source.

> > > I am happy to receive bug reports, more to receive patches (with
> > > explanation) but very unhappy with dpatches to my modes in a package I
> > > maintain - without explanation about the bug they intend to fix.
> > 
> > If you refer to rst.dpatch and grep.dpatch it is more than self-evidently
> > what's wrong there.
> 
> I did not find it out yet.

There were cvs conflict marks in the source.

> > Inspired by this I investigated much work in checking the modes and I
> > found great many missing autoload()s. See my next commit.
> 
> "Normal" and drop-in modes must not have missing autoloads().

I think we need rules they define what is a sane mode. Firstly, I would
claim the mode must be loadable without any further actions, e.g. after
a successful install of the package it must be possible to run

jed -batch -n -l MODE

If this fails, we missed anything in /etc/jed.d/50jed-extra.sl or the
mode is broken.

> it saves a lot of autoload() lines in the code,

How much? Four? Five?

> eases maintaining and makes the modes smaller.

10 Bytes?

> > > > * contents.txt:
> > > 
> > > Please only remove lines with modes not found in jedmodes.sf.net/mode/
> > > (There are modes listed at Jedmodes with the sources outside the CVS
> > > archive.)
> > 
> > If I consider this file as part of the Debian package I see no reason why
> > we should keep track of modes not found in the orig.tar.gz.
> 
> For the record. There are interesting modes from other places that we
> might want to add at a later point. 

Do you have any suggestions?

-- 
Im Leben lernt der Mensch als erstes das Gehen und Sprechen.
Später lernt er still zu sitzen und den Mund zu halten.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-jed-devel/attachments/20060526/14ce1db5/attachment.pgp