Please allow jedstate_0.5.4.transitional.1-1 and jed-extra_2.2.1-1.etch.1

[Rafael Laboissiere]

* Steve Langasek <vorlon at debian.org> [2007-02-12 03:57]:

> On Sun, Feb 11, 2007 at 03:49:27PM +0100, Rafael Laboissiere wrote:
> > > Your postinst is run with set -e, but cmd1 && cmd2 will only return true if
> > > both commands succeed.  So while this shell code correctly short-circuits,
> > > it also causes the postinst to exit non-zero whenever $dir/hook is absent or
> > > has been modified, which doesn't seem to be the intent.
> 
> > > You probably want this instead:
> 
> > > 	if test -f $dir/$hook                                        \
> > >            && echo "$chksum  $dir/$hook" | md5sum -c >/dev/null 2>&1
> > > 	then
> > > 		rm -f $dir/$hook
> > > 	fi
> > >         if test -d $dir; then
> > > 		rmdir --ignore-fail-on-non-empty $dir
> > > 	fi
> 
> > > Sorry for not noticing this in my earlier review.
> 
> > Version 0.5.4.transitional.1-5, containing the changes above, is uploaded to
> > unstable.  Please consider unblocking it for testing, if everything is okay
> > this time.
> 
> Unblocked now.  Thanks for your work!

Thanks for your work, too.
 
-- 
Rafael