[g.milde@web.de: Re: 0.99.18-9 released]

[Rafael Laboissiere]

[Günter, I am forwarding to pkg-jed-devel your message below.  I think you
meant it for the mailing list. -- R.]


----- Forwarded message from "G. Milde" <g.milde at web.de> -----

From: "G. Milde" <g.milde at web.de>
Subject: Re: 0.99.18-9 released
Date: Fri, 19 Jan 2007 16:08:58 +0100
To: Rafael Laboissiere <rafael at debian.org>
Message-ID: <20070119150858.GA5931 at localhost>

On 19.01.07, Rafael Laboissiere wrote:
> 0.99.18-9 was not released to unstable in order to avoid interference with
> 0.99.18-8, which should enter testing in less than one week from now.

This is fine.

> Before releasing 0.99.18-10 to unstable, it would be great if we could
> address the remaining issues:

> * fix-pymode-tab-space: it seems that there is not yet consensus
>   about this patch.  Could you (JS and GM) try to reach it?

Let me propose a "minimal invasive | least common denominator"
suggestion:

1. replace uses of whitespace() for indentation with py_whitespace()

 private define py_whitespace(n)
 {
    if ( get_blocal_var("py_use_tab") )
      {                                
         $1 = USE_TABS;
         USE_TABS = 1;
         whitespace(n);
         USE_TABS = $1;
      }   
    else
      insert_spaces(n);
 }

(If Jörg prefers his variant with 

  loop (n / TAB) insert_char('\t');
         n -= n / TAB * TAB;

 this would be OK as well. Let us assume that the case that someone sets
 TAB to 0 after the call to python_mode is so rare it practically doesnot
 appear. (Although it is not impossible and would lead to a strange error.)
)

2. no change should be done to the initialization of tab- or
   space-indention for new files,
   (After all, this is not the topic of the bug report we want to adress.)
   
 % Set the following to your favourite indentation level
+% if Py_Indent_Level is 8, hard tabs will be used for indentation
 custom_variable("Py_Indent_Level", 4);

3. Test indented code lines 
     for "\t" in case use_tabs is 0, or
     for " " in case use_tabs is 1.
   to override the default setting with the value used in the file.

> * Fix the outstanding bugs:
>   #306223: jed: Does not scroll back properly after wordwrap when HORIZONTAL_PAN is negative
>   #330825: xjed: pasting with middle mouse button into an open mark fails

These are IMO things to fix upstream, as the problem is "hidden" in the
core of jed. That means they will only be available in jed 0.99.19 (if we
do not backport fixes).


----- End forwarded message -----