[RFU?] jed 0.99.19~pre95-2 [was: Re: r791 - in jed/branches/0.99.19/debian: . patches]

[G. Milde]

On  4.07.07, Jörg Sommer wrote:

> BTW: Do you or Günter know a reason, why John didn't merge in the
>   x-keydefs? I think these keys are really usefull for help.sl and I
>   would like to merge it.

I'd rather say that John did not see a compelling reason to merge the
additional definitions. (As this involves not only the actual work to
merge, but also testing and a commitment to maintain once it is in the
standard distro.) John's main interst is Jed's platform independence
while the special keydefs are quite PC keyboard specific.

I'd like to see the first part of x-keydefs (the "generic" key variables)
moved to keydefs.sl so that x-keydefs.sl would only contain the
additional definitions for xjed. This would also simplify the code, as

  % We need to trick the function check for non-X jed (we cannot use #ifdef
  % XWINDOWS, as the byte-compiled file should be usable with jed on a console
  % as well.)
  private variable x_set_keysym_p = __get_reference("x_set_keysym");

is no longer needed in this case.

A second difference between the standard keydefs.sl and x-keydefs.sl is the
definition of the auxiliary fun:

   private define setkey_via_terminfo (tc, def)

vs.

   private define set_keyvar(ibmpc, termcap, default)

The latter variant allows to merge the IBMPC definitions resulting in a
more compact keydefs file.

I already did such a merge but did not publish, see attachment.
Maybe you can convince John to include it in the standard library.
We could also consider using it in jed-common and provide John with a
use-case (an maybe bugfixes).

Günter