slsh/local-packages
Jörg Sommer
joerg at alea.gnuu.de
Mon Apr 14 11:00:10 UTC 2008
Hallo G.,
G. Milde schrieb am Mon 14. Apr, 11:11 (+0200):
> --- /usr/share/jed/lib/site.sl 2007-09-09 19:41:00.000000000 +0200
> +++ /home/milde/.jed/lib/test/site.sl 2008-04-14 10:36:19.000000000 +0200
> @@ -3248,14 +3248,17 @@
> # ifexists _slang_install_prefix
> _slang_install_prefix,
> # endif
> - guess_jed_install_prefix ()
> + guess_jed_install_prefix (),
Is this intended?
> ])
> {
> $1 = ();
> - $1 = path_concat ($1, "share/slsh/local-packages");
> + $1 = path_concat ($1, "share/slsh");
> + if (2 != file_status ($1))
> + continue;
> + set_jed_library_path (strcat (get_jed_library_path (), ",", $1));
> + $1 = path_concat ($1, "local-packages");
> if (2 != file_status ($1))
> continue;
Should it really continue in this case? There's a break at the end of
this block. I would put the set_jed_library_path() into the then branch.
> - set_jed_library_path (strcat (get_jed_library_path (), ",", path_dirname ($1)));
> set_jed_library_path (strcat (get_jed_library_path (), ",", $1));
> break;
> }
Apart from this the patch looks fine.
Bye, Jörg.
--
The social dynamics of the net are a direct consequence of the fact
that nobody has yet developed a Remote Strangulation Protocol.
(Larry Wall)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature http://en.wikipedia.org/wiki/OpenPGP
Url : http://lists.alioth.debian.org/pipermail/pkg-jed-devel/attachments/20080414/abc61bee/attachment.pgp
More information about the Pkg-jed-devel
mailing list