Bug#477450: john-data arch:all package build in binary-arch target

[Gerfried Fuchs]

reopen 477450
found 477450 1.7.2-3
thanks

* David Paleino <d.paleino at gmail.com> [2008-04-26 19:00:34 CEST]:
> On Wed, 23 Apr 2008 11:51:29 +0200, Gerfried Fuchs wrote:
> >  While producing the backport for the new john package (thanks a lot for
> > the longstanding update!) I noticed that the produce john-data package
> > is produced in the binary-arch target.
> > 
> >  Please notice the debhelper switches -i(ndependent) and -s(ame arch)
> > and use them appropriately in the different targets. When building with
> > the -B switch the arch:all packages shouldn't get produced, leaving
> > cruft on the build daemon hosts.
> 
> Yes, sorry for that (I didn't know any consequence of that design).
> 
> I've added a "binary-common" target, and made binary-{arch,indep} depend on it.

 Erm, that doesn't change anything. It still calls the dh_scripts
without any switch. If you want to go on with this design, I suggest the
following patch for you to fix it:

#v+
--- Debian/backport/john/1.7.2-3/john-1.7.2/debian/rules.orig	2008-06-03 11:34:41.000000000 +0200
+++ Debian/backport/john/1.7.2-3/john-1.7.2/debian/rules	2008-06-03 11:40:47.000000000 +0200
@@ -98,8 +98,11 @@
 	dh_md5sums
 	dh_builddeb
 
-binary-indep: build install binary-common
-binary-arch: build install binary-common
+binary-indep: build install
+	$(MAKE) -f debian/rules DH_OPTIONS=-i binary-common
+
+binary-arch: build install
+	$(MAKE) -f debian/rules DH_OPTIONS=-s binary-common
 
 binary: binary-indep binary-arch
 
#v-

> The problem is that I've already sent a 1.7.2-2 package to my sponsor, who
> uploaded it immediately. I believe it'll take a while before 1.7.2-3 (fixing
> this) can be uploaded :(.

 Hmm, I wonder what checks your sponsor did do actually, if any. :/

 So long,
Rhonda