[Pkg-kde-bugs-fwd] [Bug 99089] Cannot send inline OpenPGP-signed messages

Till Adam 99089@bugs.kde.org
26 Jun 2005 10:58:57 -0000


------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
         
http://bugs.kde.org/show_bug.cgi?id=99089         
adam kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From adam kde org  2005-06-26 12:58 -------
SVN commit 429061 by tilladam:

Fix by Thiago Macieira <thiago kde org> for ingored signature type
selections. 

Marc, this seems correct to me. How about
resolveSigningKeysFroEncryption and resolveEncryptionKeys? Do they have
the same problem?

BUG: 99089
CCMAIL: marc kdab net


 M  +4 -2      keyresolver.cpp  


--- trunk/KDE/kdepim/kmail/keyresolver.cpp #429060:429061
 @ -2,7 +2,7  @
     keyresolver.cpp
 
     This file is part of libkleopatra, the KDE keymanagement library
-    Copyright (c) 2004 Klarälvdalens Datakonsult AB
+    Copyright (c) 2004 Klarälvdalens Datakonsult AB
 
     Based on kpgp.cpp
     Copyright (C) 2001,2002 the KPGP authors
 @ -1028,8 +1028,10  @
   CryptoMessageFormat commonFormat = AutoFormat;
 
   for ( unsigned int i = 0 ; i < numConcreteCryptoMessageFormats ; ++i ) {
+    if ( !(mCryptoMessageFormats & concreteCryptoMessageFormats[i]) )
+      continue; // skip
     if ( signingKeysFor( concreteCryptoMessageFormats[i] ).empty() )
-      continue; // skip;
+      continue; // skip
     if ( count.numOf( concreteCryptoMessageFormats[i] ) == count.numTotal() ) {
       commonFormat = concreteCryptoMessageFormats[i];
       break;