rev 20406 - in kde-extras/kwave/trunk/debian: . patches

[Pino Toscano]

Author: pino
Date: 2016-03-25 11:06:40 +0000 (Fri, 25 Mar 2016)
New Revision: 20406

Added:
   kde-extras/kwave/trunk/debian/patches/plugins-not-executable.diff
Modified:
   kde-extras/kwave/trunk/debian/changelog
   kde-extras/kwave/trunk/debian/patches/series
Log:
fix loading of plugins

do not require executable permissions on them


Modified: kde-extras/kwave/trunk/debian/changelog
===================================================================
--- kde-extras/kwave/trunk/debian/changelog	2016-03-25 10:30:08 UTC (rev 20405)
+++ kde-extras/kwave/trunk/debian/changelog	2016-03-25 11:06:40 UTC (rev 20406)
@@ -24,6 +24,8 @@
   * Use https for the Vcs-Browser field.
   * Bump Standards-Version to 3.9.7, no changes required.
   * Link in as-needed mode.
+  * Fix loading of plugins, by not requiring executable permissions on them;
+    patch plugins-not-executable.diff.
 
  -- Debian KDE Extras Team <pkg-kde-extras at lists.alioth.debian.org>  Fri, 25 Mar 2016 10:25:08 +0100
 

Added: kde-extras/kwave/trunk/debian/patches/plugins-not-executable.diff
===================================================================
--- kde-extras/kwave/trunk/debian/patches/plugins-not-executable.diff	                        (rev 0)
+++ kde-extras/kwave/trunk/debian/patches/plugins-not-executable.diff	2016-03-25 11:06:40 UTC (rev 20406)
@@ -0,0 +1,34 @@
+Author: Pino Toscano <pino at debian.org>
+Description: Do not require executable permissions on plugins.
+ There is no need for plugins to have executable permissions, as they work fine
+ without them.  Also, libraries have these permission bits stripped in Debian
+ systems, breaking the plugin loading.
+ .
+ No need to forward this upstream, since there is a KPluginLoader-based system
+ there now.
+Last-Update: 2016-03-25
+Forwarded: not-needed
+
+--- a/libkwave/PluginManager.cpp
++++ b/libkwave/PluginManager.cpp
+@@ -632,7 +632,7 @@ void Kwave::PluginManager::searchPluginM
+ 	QDir d(dir);
+ 	qDebug("searching for plugins in '%s'", DBG(dir));
+ 	QStringList f = d.entryList(
+-	    QDir::Files | QDir::Readable | QDir::Executable, QDir::Name);
++	    QDir::Files | QDir::Readable, QDir::Name);
+ 	foreach (const QString &file, f) {
+ 	    if (file.startsWith(_("kwaveplugin_")))
+ 		files += d.path() + sep + file;
+--- a/plugins/CMakeLists.txt
++++ b/plugins/CMakeLists.txt
+@@ -65,9 +65,6 @@ MACRO(KWAVE_PLUGIN _plugin)
+         plugin_${_plugin}
+         LIBRARY
+         DESTINATION ${PLUGIN_INSTALL_DIR}
+-        PERMISSIONS OWNER_READ OWNER_WRITE OWNER_EXECUTE
+-                    GROUP_READ GROUP_EXECUTE
+-                    WORLD_READ WORLD_EXECUTE
+     )
+ 
+ ENDMACRO(KWAVE_PLUGIN)

Modified: kde-extras/kwave/trunk/debian/patches/series
===================================================================
--- kde-extras/kwave/trunk/debian/patches/series	2016-03-25 10:30:08 UTC (rev 20405)
+++ kde-extras/kwave/trunk/debian/patches/series	2016-03-25 11:06:40 UTC (rev 20406)
@@ -1,2 +1,3 @@
 07-no-rpath
 cmake-verbose.diff
+plugins-not-executable.diff