[pkg-kolab] Various tweaks against the svn trunk

[Philip Hands]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi

I've finally got round to having time to have another play with the debian
packages.  Nice to see that we now have 2.1.0 in SVN -- well done :-)

I just installed kolab from lenny on an otherwise mostly etch system, and
found some issues, so then checked out the svn trunk for what I'm assuming
to be the responsible packages, and knocked up some patches to deal with
some of it -- I don't want to just bung the changes back into svn without
giving people a chance to say that I'm fixing the problem in a broken
manner, so here are some patches and other comments.

1) kolab-resource-handlers sites-available/kolab

This symlink is wrong, and so stops successful installation as apache2 will
not restart if the symlink is hanging:

Patch:

Index: debian/links
===================================================================
- --- debian/links        (revision 689)
+++ debian/links        (working copy)
@@ -1 +1 @@
- -etc/kolab/apache.conf etc/apache2/sites-available/kolab
+etc/kolab/kolab-webadmin-apache.conf etc/apache2/sites-available/kolab

2.1) postfix aliases not set up properly

I note that running kolab_bootstrap leaves me with a main.cf including this:

  alias_maps = hash:
  alias_database = hash:

I'd suggest adding a line:

  aliases_file=${sysconfdir}/aliases

to dist_conf/debian, presumably by updating debian/patches/10-dist_conf.dpatch

2.2) postfix canonical & relocated files

These are referred to in the main.cf, but not created or postmap-ed, so
give rise to errors

2.3) amavis

The master.cf is setup to use amavis, so I'd have thought that kolabd
should at least recommend amavisd-new

2.4) minor tidying of 10-dist_conf.dpatch

- -sasl_smtpconffile=/etc/postfix/sasl/smtpd.conf
+sasl_smtpconffile=${sysconfdir}/postfix/sasl/smtpd.conf


3) postfix's master.cf

All instances of 'flags=n' should be replaced with 'null_sender=' and a
version dependency should be added to ensure that we get a recent enough
pipe to support that option

$emailserver_master_usr is not being defined in dist_conf/debian, so we
should either do that, or change @emailserver_master_usr@ to
@emailserver_musr@, say.

kolabfilter.php and kolabmailboxfilter.php reside in /etc/kolab so:

- -    -f @resmgr_scriptsdir@/kolabfilter.php
+    -f @resmgr_confdir@/kolabfilter.php
...
- -    -f @resmgr_scriptsdir@/kolabmailboxfilter.php
+    -f @resmgr_confdir@/kolabmailboxfilter.php

Also, /etc/kolab/resmgr.conf has restricted permissions (root:www-data)
which means that if kolabfilter.php is run as kolab for example, it's
unable to read that config file -- so should kolabfilter.php be running as
something else, or should that file belong to kolab:www-data?

4) /etc/kolab-webadmin/session-vars.php

It would be nice if this was populated by the kolab_bootstrap script.


I think that's it for now -- Hope that helps.

Cheers, Phil.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG+lxDYgOKS92bmRARArGCAJ4wMC9sgD/mcutFBFXgUX6zI7lCxQCffNtO
d2oI84u87cbbgGLhLZUoLRQ=
=R8YR
-----END PGP SIGNATURE-----