[pkg-kolab] libkolab(xml): New upstream version available

Maximiliano Curia maxy at gnuservers.com.ar
Sun Jun 29 17:05:37 UTC 2014


¡Hola Diane!

El 2014-06-29 a las 00:25 -0700, Diane Trout escribió:
> Hello,

> I have versions of libkolab/libkolabxml that I think are ready for kdepim-
> runtime. Everything but the release tag for those archives has been committed
> to alioth.

> I have built both packages, and modified a checkout of kdepim-runtime from
> experimental to link against them. Then I created a calendar event and made
> sure it showed up in the kolab calendar roundcube plugin.

> http://mentors.debian.net/package/libkolabxml
> http://mentors.debian.net/debian/pool/main/libk/libkolabxml/libkolabxml_1.0.1-1.dsc

> http://mentors.debian.net/package/libkolab
> http://mentors.debian.net/debian/pool/main/libk/libkolab/libkolab_0.5.2-1.dsc

> The changes I made from Paul Klos:

> * Both packages
>   * Updated standards version to 3.9.5.
>   * Added symbols files.
>   * Added myself to uploaders
>   * Updated vcs-git to canonical url.

> * libkolabxml
>   * added libcurl4-gnutls-dev dependency to -dev package

> * libkolab
>   * force using python2.7 for build as if it can swig will try 3.3
>   * add patch to make python-kolab package importable in python
>   * updated to 0.5.2 (from Paul Klos's 0.5.0)

> I looked at libkolabxml's copyrights, and barely glanced at libkolab.

> Hope that's good enough to unblock 4.13.

Thanks a lot for your work, here is my review about the packages:
libkolabxml
debian/changelog:
 - The new default urgency is medium, is there any reason to use low?

debian/control:
 - The continuation fields are filled with tabs instead of spaces, which is a
   bit unusual, and at least my vim configuration doesn't recognize them.
   A call the wrap-and-sort may be worth it.

debian/copyright:
 - Files: compiled/{grammar-input-stream,xsdbin}.*
   Are: Copyright: Boris Kolpackov <boris at codesynthesis.com>
        License: public-domain
         In xsd/LICENSE all files are published under GPL-2
   (snippet from the xsd package)

 - Files: src/containers/kolabfreebusy.cpp
          tests/parsingtest.cpp
          tests/parsingtest.h
          tests/validationtest.cpp
          tests/validationtest.h
   Are: Copyright: 2012-2013, Christian Mollekopf <mollekopf at kolabsys.com>
        License: LGPL-2.1+

Sort of self contained transition needed for libkolabxml0 -> libkolabxml1:

title = "libkolabxml1";

is_affected = .depends ~ /libkolabxml0/
            | .depends ~ /libkolabxml1/
            | .build-depends ~ /libkolabxml-dev/;

is_good = .depends ~ /libkolabxml1/;
is_bad = .depends ~ /libkolabxml0/;

affected packages: libkolab kdepim-runtime

libkolab
debian/changelog:
 - The new default urgency is medium, is there any reason to use low?

debian/control:
 - The continuation fields are filled with tabs instead of spaces, which is a
   bit unusual, and at least my vim configuration doesn't recognize them.
   A call the wrap-and-sort may be worth it.

debian/copyright:
 - copyright format 1.0 is intended to be processed from top to bottom, so
   having a Files: * after a Files: debian/* would invalidate the debian/*
   section.
 - Files: kolabformat/xmlobject.* are:
   Copyright: 2012, Christian Mollekopf <mollekopf at kolabsys.com>
   License: AGPL-3+

 - Files: * is missing 2012, Sofia Balicka <balicka at kolabsys.com> in
   the list of copyright holders
   and the year 2013 for Christian Mollekopf

 - Files: icalendar/icalendar.* icalendar/imip.* are:
   Copyright: 2012, Christian Mollekopf <chrigi_1 at fastmail.fm>
   License: LGPL2.1+

 - Files: cmake/modules/* are under:
 Copyright: 2006, Alexander Neundorf <neundorf at kde.org>
            2006, Allen Winter <winter at kde.org>
            2009, Sebastian Trueg <trueg at kde.org>
 License: BSD-3-clause
 Redistribution and use in source and binary forms, with or without
 modification, are permitted provided that the following conditions
 are met:
 .
 1. Redistributions of source code must retain the copyright
    notice, this list of conditions and the following disclaimer.
 2. Redistributions in binary form must reproduce the copyright
    notice, this list of conditions and the following disclaimer in the
    documentation and/or other materials provided with the distribution.
 3. The name of the author may not be used to endorse or promote products
    derived from this software without specific prior written permission.
 .
 THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR IMPLIED
 WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
 MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.  IN NO
 EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
 PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS;
 OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
 WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR
 OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
 ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

debian/patches/add-linker-flags.patch
 - How is that this patch is needed? Why is that cmake is not honouring
   LDFLAGS?

Thanks again, and happy hacking,
-- 
"Whenever possible, steal code." -- Tom Duff
Saludos /\/\ /\ >< `/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-kolab-devel/attachments/20140629/66a1f073/attachment.sig>


More information about the pkg-kolab-devel mailing list