[pkg-kolab] Bug#817808: php-kolab: postrm is buggy, breaks upgrades

Sandro Knauß bugs at sandroknauss.de
Mon Mar 14 01:15:41 UTC 2016


Control: tags -1 +pending

Hi,

thanks for repothing.
Yes you are right, that the quoting was not correct but it is remove_model 
that is incorrect:

> remove_module () {
>         local step=$1 module=$2 inifile=$2.ini package=$3 args=$4
> ...
> }

changed to: 

 remove_module () {
         local step=$1 module=$2 inifile=$2.ini package=$3 args="$4"
 ...
 }

this is correct:
 
> remove_module $1 kolab php-kolab "$*"
> remove_module $1 kolabdummy php-kolab "$*"

$* is actually all arguments as single argument $@ would split the args in 
different arguments, and $4 should get all aguments and with $@ $4 not get all 
arguments. But because dash automatically splits the arguments, we have to add 
quotes around $4.

Fixed already in git master d0a6e11

regards,

sandro
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.alioth.debian.org/pipermail/pkg-kolab-devel/attachments/20160314/cc99b77c/attachment.sig>


More information about the pkg-kolab-devel mailing list