[pkg-lighttpd] First issue, patch system?

[Torsten Marek]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Krzysztof,

thanks for creating the mailing list! I'll inaugurate it with a technical mail.

While I was rebooting my machine, I found out that lighttpd needs the SHELL
environment variable set to be able to execute include_shell directives in the
configuration file. Maybe you already saw it, but the creation of the file
extension -> mimetype dictionary (or hash, if you prefer) is done by a perl
script, using /etc/mime.types. Thus, lighttpd fails when it is started by init
rather than a user.

The code is in proc_open.c, l. 154
if (NULL == (shell = getenv(SHELLENV))) {
    fprintf(stderr, "env %s is required", SHELLENV);
    return -1;
}

where SHELLENV contains "SHELL" on POSIX. Couldn't "shell" just be hardcoded to
 /bin/sh?

Following that, which patch system should we use? I've been working with dpatch
mostly and am quite satisfied with it, but I know that some devs don't like it.

greetings

Torsten
- --
Torsten Marek <shlomme at gmx.net>
ID: A244C858 -- FP: 1902 0002 5DFC 856B F146  894C 7CC5 451E A244 C858
Keyserver: subkeys.pgp.net

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDhhbYfMVFHqJEyFgRAuhCAKCGcH1zIv+Kl24VKuxjavnGjYhxmQCbBElO
2AV+j6QQU1J9cuSmp0lAC58=
=k/iJ
-----END PGP SIGNATURE-----