[pkg-lighttpd] Bug#383425: Bug#383425

[Pierre Habouzit]

On Wed, Nov 14, 2007 at 01:53:33PM +0000, M. Koehrer wrote:
> Hello!
> I also had a look to that issue.
> In my opinion, the difference is the postinst script in the .deb package.
> I compared it with the postinst script of an Apache2 package.
> In Apache2 there is the line
>                 invoke-rc.d apache2 start || true
> to start the apache2 server.
> In lighttpd the corresponding script line is 
>                 invoke-rc.d lighttpd start || exit $?
> That means, apache takes a non-starting server as ok and still sees the package as well installed.
> Lighttpd sees the non-starting server as error and it is seen as not installable.
> 
> I propose to modify the postinst script in the lighttpd .deb package to replace the lines from above
> by the lines uses with the Apache2 server. 
> In case of an error (e.g. if port 80 is already in use), lighttpd does not start but it will be properly installed.
> This should solve the problems mentioned by all the reporters to this bug.

  this is a very bad idea because it hides real issues with the server
to the admin. The proper solution is in the postinst, if:
  1. it is a fresh install ;
  2. we know that something is listening on the :80 port ;

  then if the start failed we can assume that it was because of another
httpd. Though, we will print in big fat letters that the admin _has_ to
fix the configuration first thing after this apt run, or the next
upgrade will break.

  I'll try to implement that, though I'm unsure how to do that reliably.

  but ignoring errors is just so bad practice that it makes me scream.

-- 
·O·  Pierre Habouzit
··O                                                madcoder at debian.org
OOO                                                http://www.madism.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-lighttpd-maintainers/attachments/20071114/74c84527/attachment-0001.pgp