[pkg-lighttpd] Bug#590097: (no subject)

[Olaf van der Spek]

On 14-9-2010 18:42, Ximin Luo wrote:
> On 03/09/10 14:47, Olaf van der Spek wrote:
>> I think this is better solved by adding generic pre- and post-rotate
>> hooks to logrotate.
>>
>> Olaf
>>
>
> could you elaborate? i don't understand what you mean, logrotate already has
> pre- and post-rotate hooks.
>
> some packages (P) would like to process the logs of a certain type of service
> (S). P needs to know when S's logs are being rotated; the issue here is how.
>
> so far we've discussed two options:
> (1) P can go fiddling about in S's logrotate scripts, or
> (2) S can call P using the rotate hooks. the solution i mentioned in those bug
> reports is general enough to handle multiple S and multiple P.
>
> are you suggesting that logrotate handle this process? i don't see a way to do
> this that's simpler than (2). for example, the simplest way i can think of:
>
> - lighttpd tells logrotate "i'm a webserver"
> - awstats tells logrotate "i want to process webserver logs"
> - logrotate can do the rest
>
> is just adding an unnecessary middle man.

That only has to be implemented once.
Your approach requires a lot of code duplication.

Olaf