[Pkg-lirc-maint] [RFR] templates://lirc/{lirc-modules-source.templates, lirc.templates}

MJ Ray mjr at phonecoop.coop
Fri Sep 7 10:36:08 UTC 2007


Christian Perrier <bubulle at debian.org> wrote:
> Please send reviews as unified diffs (diff -u) against the original
> files. Comments about your proposed changes will be appreciated.

The original files don't seem to be attached.  Did you mean your
modified files?

However, my suggested changes to this one are small:

> + The list of needed kernel modules and their parameters may be
> + guessed from your previous answers.

"Needed" seems vague here - how badly does it need them?  We have a
richer collection of adjectives that we use for needed packages - can
we use them here?  Do we mean required or suggested or what?  There's
also an "unneeded" later which sounds unnatural to me.

> + .
> + Please choose whether you want such automatic selection to happen.
>
> Summarize the action we expect from the user.

More direct: "Please choose whether to do this automatic selection."

Hope that helps,
-- 
MJR/slef
My Opinion Only: see http://people.debian.org/~mjr/
Please follow http://www.uk.debian.org/MailingLists/#codeofconduct




More information about the Pkg-lirc-maint mailing list