[Pkg-lirc-maint] Bug#458516: lirc-modules-source: cannot build lirc_dev on 2.6.23-1

[Richard Antony Burton]

Package: lirc-modules-source
Version: 0.8.0-13
Severity: grave
Tags: patch
Justification: renders package unusable

This is probably a duplicate of 457858, but since there are no real details
given I don't want to hijack it. Please merge mine with it if you want to.

lirc_dev does not compile, at least on 2.6.23-1, and probably earlier kernel
versions (I've been running on a newer ubuntu package for a while to get support
for my xbox remote, I'll give your experimental package a go having now spotted
it).

I have attached a patch to fix the problem. It may also be needed on your
0.8.2 package (it is on the ubuntu one of the same version).

Regards, Richard.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.23-1-686 (SMP w/1 CPU core)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages lirc-modules-source depends on:
ii  debconf [debconf-2.0]         1.5.17     Debian configuration management sy
ii  debhelper                     5.0.63     helper programs for debian/rules
ii  debianutils                   2.28.2     Miscellaneous utilities specific t
ii  ucf                           3.004      Update Configuration File: preserv

Versions of packages lirc-modules-source recommends:
ii  dpkg-dev                      1.14.14    package building tools for Debian
ii  gcc [c-compiler]              4:4.2.2-1  The GNU C compiler
ii  gcc-4.1 [c-compiler]          4.1.2-18   The GNU C compiler
ii  gcc-4.2 [c-compiler]          4.2.2-4    The GNU C compiler
ii  kernel-package                11.001     A utility for building Linux kerne
ii  make                          3.81-3     The GNU version of the "make" util

-- debconf information:
  lirc-modules-source/use_lirc_hints: true
  lirc-modules-source/parallel_irq: 7
* lirc-modules-source/do-build: false
  lirc-modules-source/parallel_timer: 65536
  lirc-modules-source/sir_type: Other
  lirc-modules-source/serial_softcarrier: false
  lirc-modules-source/kernel-source-not-found:
  lirc-modules-source/serial_transmitter: true
  lirc-modules-source/it87_type: Standard
  lirc-modules-source/not_needed:
  lirc-modules-source/serial_port: 0x2f8
* lirc-modules-source/drivers: atiusb
  lirc-modules-source/serial_irq: 3
  lirc-modules-source/serial_type: Other
  lirc-modules-source/kernel-source: /usr/src/linux/
  lirc-modules-source/sir_irq: 3
  lirc-modules-source/sir_port: 0x2f8
  lirc-modules-source/parallel_port: 0x378
* lirc-modules-source/what_next:
-------------- next part --------------
--- lirc_dev.c.orig	2007-10-03 13:40:08.000000000 +0000
+++ lirc_dev.c	2008-01-01 11:24:43.000000000 +0000
@@ -869,8 +869,7 @@
 	return SUCCESS;
 
 out_unregister:
-	if(unregister_chrdev(IRCTL_DEV_MAJOR, IRCTL_DEV_NAME))
-		printk(KERN_ERR "lirc_dev: unregister_chrdev failed!\n");
+	unregister_chrdev(IRCTL_DEV_MAJOR, IRCTL_DEV_NAME);
 out:
 	return -1;
 }
@@ -894,15 +893,8 @@
  */
 void cleanup_module(void)
 {
-	int ret;
-
-	ret = unregister_chrdev(IRCTL_DEV_MAJOR, IRCTL_DEV_NAME);
+	unregister_chrdev(IRCTL_DEV_MAJOR, IRCTL_DEV_NAME);
 	class_destroy(lirc_class);
-
-	if(ret)
-		printk("lirc_dev: error in module_unregister_chrdev: %d\n", ret);
-	else
-		dprintk("lirc_dev: module successfully unloaded\n");
 }
 
 MODULE_DESCRIPTION("LIRC base driver module");