[Pkg-lirc-maint] Bug#860065: lirc: Ignores remote configs included with absolute paths

[Matthew Gabeler-Lee]

Package: lirc
Version: 0.9.4c-9
Severity: normal

If you put a line like this in lircd.conf or one of the files it includes:

include "/absolute/path/to/remote.conf"

It will be ignored.  The problem seems to be bad interaction between these
two snippets of code in lib/config_file.c:

~ line 906 (read_all_included):
        lirc_parse_relative(buff, sizeof(buff), val, name);
        glob(buff, 0, NULL, &globbuf);
~ line 791 (lirc_parse_relative)
        if (*child == '/')
                return child;

The caller doesn't actually use the return value of lirc_parse_relative, it
assumes buff will be filled ...  but it's not.

-- System Information:
Debian Release: 9.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable'), (500, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-2-amd64 (SMP w/12 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lirc depends on:
ii  init-system-helpers  1.47
ii  libasound2           1.1.3-5
ii  libc6                2.24-9
ii  libftdi1-2           1.3-2+b2
ii  libgcc1              1:6.3.0-11
ii  liblirc-client0      0.9.4c-9
ii  liblirc0             0.9.4c-9
ii  libportaudio2        19.6.0-1
ii  libstdc++6           6.3.0-11
ii  libsystemd0          232-22
ii  libudev1             232-22
ii  libusb-0.1-4         2:0.1.12-30
ii  libusb-1.0-0         2:1.0.21-1
ii  lsb-base             9.20161125
ii  python3              3.5.3-1

Versions of packages lirc recommends:
pn  gir1.2-vte    <none>
ii  python3-gi    3.22.0-2
pn  python3-yaml  <none>

Versions of packages lirc suggests:
pn  ir-keytable          <none>
ii  lirc-compat-remotes  0.9.0-1
pn  lirc-doc             <none>
pn  lirc-drv-irman       <none>
ii  lirc-x               0.9.4c-9
ii  setserial            2.17-50

-- Configuration Files:
/etc/lirc/hardware.conf changed [not included]
/etc/lirc/lircd.conf changed [not included]
/etc/lirc/lircd.conf.d/devinput.lircd.conf [Errno 2] No such file or directory: '/etc/lirc/lircd.conf.d/devinput.lircd.conf'

-- debconf information excluded