Bug#360411: [Pkg-ltsp-devel] Bug#360411: ltsp-server: SECURITY variable broke silently

[Petter Reinholdtsen]

[Jeff]
> when I made a file /etc/ltsp/ltsp-build-client.conf so I could put
> in multiple repositories (see previous bug report), I kept in stuff
> from /usr/share/ltsp/ltsp-build-client.conf that I clearly shouldn't
> have.

Yes.  Only the configuration you need to override should be in
/etc/ltsp/ltsp-build-client.conf.  There is no need to copy the
content of /usr/share/ltsp/ltsp-build-client.conf, as both files are
read by ltsp-build-client.

> A default configuration that works and can be edited might be a good
> thing.

The default configuration work alright.  We should not include a file
in /etc/ltsp/ in the package, as this will make it harder to upgrade
the package when the package-default configuration changes.

> But more importantly, when ltsp-build-client fails, it should report
> an error. If you define the SECURITY variables that are in
> /usr/share/ltsp/ltsp-build-client.conf in
> /etc/ltsp/ltsp-build-client.conf, ltsp-build-client just returns
> without an error.

It is supposed to report an error.  Or at least I thought I had
implemnted that, but I see that was in another LTSP-related script.

I suggest adding code like this to ltsp-build-client, to get it to
report if the build was ok or not when it terminates:

  on_exit() {
    [...]
    if [ true = "$run_successfull" ] ; then
	echo "info: conversion ended successfully"
    else
	echo "error: conversion ended abnormally"
    fi
  }
  trap on_exit EXIT
  [...]
  run_successfull=true # report success to on_exit()
  exit 0