Bug#405772: [Pkg-ltsp-devel] Bug#405772: ltsp-client: also fix SWAP related booleans

Petter Reinholdtsen pere at hungry.com
Sun Jan 7 16:45:12 UTC 2007


[Vagrant Cascadian]
> +get_boolean(){
> +    case "$(echo $1 | tr 'A-Z' 'a-z')" in
> +       true|y|yes) return 0 ;; 
> +       *) return 1 ;; 
> +    esac
> +}

I'm not sure if this is a good function name for that operation.  What
about boolean_is_true() or something like that.  get_boolean()
indicate to me that it should return the value, and I expect to be
able to use it like VAL=`get_boolean $VAL`, and that is not the case
with this function.

Besides this minor point, the patch look good to me.

Friendly,
-- 
Petter Reinholdtsen




More information about the Pkg-ltsp-devel mailing list