[Pkg-ltsp-devel] Bug#477999: screen script "startx" checks for XFCFG variable in wrong way.

[Erik Thiele]

Package: ltsp-server
Version: 5.0.40~bzr20080319-1

/opt/ltsp/i386/usr/share/ltsp/screen.d/startx:

# If XFCFG is defined then attempt to use it instead of autoconfiguration
if [ -e ${XFCFG} ]; then
    XF_ARGS="$XF_ARGS -config ${XFCFG}"
fi

this code is wrong. it adds "-config" without anything behind it, if XFCFG is 
unset. thus i get a X calling line like this:

X -query 192.168.1.1 -config -terminate vt11 :10.0

obviously either -config must be gone or the filename of a configfile has to 
be passed.

this code would probably work better:


# If XFCFG is defined then attempt to use it instead of autoconfiguration
if [ -z "${XFCFG}" ]; then
    true
else
    if [ -e "${XFCFG}" ]; then
        XF_ARGS="$XF_ARGS -config ${XFCFG}"
    fi
fi


thx
cya
erik