[Pkg-ltsp-devel] Bug#490897: tcsh logins

[Daniel Nilsson]

On Wed, Aug 13, 2008 at 01:46:14PM -0700, Vagrant Cascadian wrote:

> > --- ldm-2.0.9.orig/src/ldm.c
> > +++ ldm-2.0.9/src/ldm.c
> > @@ -268,7 +268,7 @@
> >       * FIXME: ditch the kill -1 and use ssh -o exit on the
> > control socket
> >       */
> >      command = g_strjoin(" ", "ssh", "-Y", "-t", "-S",
> > ldm.control_socket,
> > -            "-l", ldm.username, ldm.server, client_env,
> > +            "-l", ldm.username, ldm.server, "env" ,client_env,
> >              lang ? lang : "", display ? display : "", sound ?
> > sound : "",
> >              ldm.session, localdev ? localdev : "",
> >              "; kill -1 $PPID", NULL);
> > 

> i set a user's default shell to tcsh and was able to log in using
> ldm 2.0.9-1. today, i'm not able to do so using 2.0.11-1. *sigh* i don't
> know what happened.
> 
> i'll test your patch and if it works well, will get it upstream and
> hopefully into the version of ldm in lenny, as it seems simple.

Hi,

Please test this patch first, what I found was that I was able to
login as a tcsh user but the logout seems to hang after the Xsession
has ended (gnome-session in my testcase). I think this is due to the
"kill -1 $PPID" and the end of the ssh command above, the $PPID
variable is not available in a tcsh as far as I know. I don't know
what the correct way to do this is so that it doesn't depend on the
user shell, there is comment in the code:


    /*
     * FIXME: ditch the kill -1 and use ssh -o exit on the control
    socket 
     */
    command = g_strjoin(" ", "ssh", "-Y", "-t", "-S", ldm.control_socket,
            "-l", ldm.username, ldm.server, "env" ,client_env,
            lang ? lang : "", display ? display : "", sound ? sound : "",
            ldm.session, localdev ? localdev : "",
            "; kill -1 $PPID", NULL);

I think that should be ssh -O exit though, but I haven't tested this
yet.

-- 
Daniel Nilsson