[Pkg-ltsp-devel] Bug#590268: ltsp-server: Try to umount /opt/ltsp/i386//proc during chroot build

[Petter Reinholdtsen]

Package:  ltsp-server
Version:  5.2.3-1
Severity: minor
Tags:     patch

When the chroot_mount function is used like this in the ltsp build
code

  chroot_mount proc /proc "-t proc"

the resulting code end up adding /opt/ltsp/i386//proc to
$CHROOT_MOUNTED.  I propose to handle mount paths with and without
leading / differently to avoid this.

Here is a patch implementing the change:

--- ltsp-5.2.3-pere/server/ltsp-build-client    2010-07-06 05:38:10.000000000 +0200
+++ ltsp-5.2.3/server/ltsp-build-client 2010-07-25 14:38:29.000000000 +0200
@@ -119,9 +119,18 @@
 # $2 - where to mount (skip the chroot path)
 # $3 - mount extra params
 chroot_mount() {
-    if mount $3 $1 $ROOT/$2; then
-        CHROOT_MOUNTED="$CHROOT_MOUNTED $ROOT/$2"
-    fi
+    case "$2" in
+       /*)
+           if mount $3 $1 $ROOT$2; then
+               CHROOT_MOUNTED="$CHROOT_MOUNTED $ROOT$2"
+           fi
+           ;;
+       *)
+           if mount $3 $1 $ROOT/$2; then
+               CHROOT_MOUNTED="$CHROOT_MOUNTED $ROOT/$2"
+           fi
+           ;;
+    esac
 }

 ####################################

Happy hacking,
-- 
Petter Reinholdtsen