[Pkg-ltsp-devel] Bug#693496: /usr/sbin/ltsp-update-image: fails when /bin/sh points to bash

[Vagrant Cascadian]

Package: ltsp-server
Version: 5.4.2-2
Severity: important
File: /usr/sbin/ltsp-update-image
Control: clone -1 -2 
Control: reassign -2 ltsp-client-core
Control: retitle -2 /usr/share/ltsp/update-kernels: fails when /bin/sh points to bash
Control: found -2 5.4.2-2

When running "ltsp-update-image / --cleanup", and /bin/sh is a symlink to 
bash, ltsp-update-image fails ending with the error:

/usr/sbin/ltsp-update-image: line 57: local: `-': not a valid identifier

This appears to be the code in:

trap_cleanup() {
    # Don't stop on errors within this function.
    # local - means "restore flags on function exit".
    local -

...


There appears to be similar code in /usr/share/ltsp/update-kernels:

kernel_versions() {
    local - kernels arch loop_kernels kernel

...

Which issues a similar error:

  /usr/share/ltsp-update-kernels: line 54: local: `-': not a valid identifier


With /bin/sh symlinked to dash, it works fine.

Removing the "-" seems to work fine, but I'm not exactly clear on it's actual
purpose.


live well,
  vagrant