[Pkg-ltsp-devel] Bug#747178: ltsp-client-core: ltsp-localapps fails if user's /etc/passwd shell is missing on client

[root]

Package: ltsp-client-core
Version: 5.4.2-6+deb7u1
Severity: normal
Tags: patch

Dear Maintainer,

I have been debugging why ltsp-localapps was having no effect on my LTSP 
setup. The problem is that on the server I use /bin/zsh as my default 
shell, but this is not installed on the client. Obviously I could add 
all possible shells to the client, but this doesn't make it so 'thin'.

My fix is to add -s /bin/sh to the su command in ltsp-localappsd:

--- usr/bin/ltsp-localappsd	2012-06-27 22:26:21.000000000 +0100
+++ /opt/ltsp/i386/usr/bin/ltsp-localappsd	2014-05-06 08:28:22.000000000 +0100
@@ -60,9 +60,9 @@
 
         logit "Executing command as username ${LDM_USERNAME}: ${LTSP_COMMAND} "
         if [ "$LTSP_COMMAND_WAIT" = "true" ]; then
-            su - ${LDM_USERNAME} -c "LANG=$LANG LANGUAGE=$LANG DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY $CLIENT_ENV ${LTSP_COMMAND}"
+            su - ${LDM_USERNAME} -s /bin/sh -c "LANG=$LANG LANGUAGE=$LANG DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY $CLIENT_ENV ${LTSP_COMMAND}"
         else
-            su - ${LDM_USERNAME} -c "LANG=$LANG LANGUAGE=$LANG DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY $CLIENT_ENV ${LTSP_COMMAND}" &
+            su - ${LDM_USERNAME} -s /bin/sh -c "LANG=$LANG LANGUAGE=$LANG DISPLAY=$DISPLAY XAUTHORITY=$XAUTHORITY $CLIENT_ENV ${LTSP_COMMAND}" &
         fi
     fi
     reset_xprop LTSP_COMMAND

Mark

-- System Information:
Debian Release: 7.5
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 3.10.38-m586mmx (PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages ltsp-client-core depends on:
ii  console-setup    1.88
ii  initramfs-tools  0.109.1
ii  iproute          20120521-3+b3
ii  kbd              1.15.3-9
ii  libc6            2.13-38+deb7u1
ii  libpopt0         1.16-7
ii  libx11-6         2:1.5.0-1+deb7u1
ii  lsb-base         4.1+Debian8+deb7u1
ii  lsb-release      4.1+Debian8+deb7u1
ii  mkelfimage       2.7-7
ii  nbd-client       1:3.2-4~deb7u4
ii  python           2.7.3-4+deb7u1
ii  syslinux         2:4.05+dfsg-6+deb7u1
ii  tftp-hpa         5.2-4

Versions of packages ltsp-client-core recommends:
ii  procps  1:3.3.3-3

Versions of packages ltsp-client-core suggests:
ii  alsa-utils                        1.0.25-4
ii  cron                              3.0pl1-124
ii  cryptsetup                        2:1.4.3-4
ii  cups-bsd                          1.5.3-5+deb7u1
ii  freerdp-x11                       1.0.1-1.1+deb7u3
ii  inputattach                       1:1.4.3-1
ii  ldm                               2:2.2.11-2
ii  libasound2-plugins                1.0.25-2
ii  ltspfsd                           1.1-2
ii  mdetect                           0.5.2.3
ii  netcat-traditional [netcat]       1.10-40
ii  ntpdate                           1:4.2.6.p5+dfsg-2
ii  numlockx                          1.2-4
ii  pulseaudio                        2.0-6.1
ii  python-serial                     2.5-2.1
ii  rsyslog [system-log-daemon]       5.8.11-3
ii  sane-utils                        1.0.22-7.4
pn  sdm-terminal | x-display-manager  <none>
ii  sshfs                             2.4-1
ii  x11-xserver-utils                 7.7~3

-- no debconf information

-- 
Mark Hindley

6, Nursery Park
Innerleithen
Peeblesshire
EH44 6JB
Scotland

+44 (0)1896 830304