[Pkg-ltsp-devel] Bug#777184: ltsp-client: insserv: script ltsp-client-setup: service ltsp-client-setup already provided!

[Vagrant Cascadian]

Control: tags -1 patch

On 2015-02-05, Andreas Beckmann wrote:
> during a test with piuparts I noticed your package failed to upgrade
> from lenny -> squeeze -> wheezy -> jessie
>
>>From the attached log (scroll to the bottom...):
>
>   insserv: script ltsp-client-setup: service ltsp-client-setup already provided!
>
> I would guess an old initscript from an ancient package is still sitting around,
> and now a new initscript with a different name providing the same facility was added.
>
> May be a candidate for 'dpkg-maintscript-helper rc_conffile'.
>
> If you can analyze where the conflicting scripts come from, I'll help looking for
> the proper fix.

The lenny and squeeze versions shipped /etc/init.d/ltsp-client-setup
(and /etc/default/ltsp-client-setup), but is no longer used by ltsp, and
could actually be harmful! I suspect many LTSP installations re-install
LTSP chroots rather than upgrade, which has probably hidden the issue
over the years...


The following patch removes the init script and corresponding
configuration file:

commit 65cd653d4a6050611f7e542ddd9d588e5e98d8ae
Author: Vagrant Cascadian <vagrant at debian.org>
Date:   Mon Feb 9 01:22:26 2015 -0800

    Remove obsolete ltsp-client-setup init script and configuration file
    using dpkg-maintscript-helper (Closes: #777184).

diff --git a/ltsp-client-core.postinst b/ltsp-client-core.postinst
new file mode 100755
index 0000000..2e56ab5
--- /dev/null
+++ b/ltsp-client-core.postinst
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+set -e
+
+rm_conffile_files="/etc/init.d/ltsp-client-setup /etc/default/ltsp-client-setup"
+for conffile in $rm_conffile_files ; do
+    dpkg-maintscript-helper rm_conffile \
+        $conffile 5.5.4-3~ ltsp-client-core -- "$@"
+done
+
+#DEBHELPER#
diff --git a/ltsp-client-core.preinst b/ltsp-client-core.preinst
new file mode 100755
index 0000000..2e56ab5
--- /dev/null
+++ b/ltsp-client-core.preinst
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+set -e
+
+rm_conffile_files="/etc/init.d/ltsp-client-setup /etc/default/ltsp-client-setup"
+for conffile in $rm_conffile_files ; do
+    dpkg-maintscript-helper rm_conffile \
+        $conffile 5.5.4-3~ ltsp-client-core -- "$@"
+done
+
+#DEBHELPER#
diff --git a/ltsp-client-core.prerm b/ltsp-client-core.prerm
new file mode 100755
index 0000000..2e56ab5
--- /dev/null
+++ b/ltsp-client-core.prerm
@@ -0,0 +1,11 @@
+#!/bin/sh
+
+set -e
+
+rm_conffile_files="/etc/init.d/ltsp-client-setup /etc/default/ltsp-client-setup"
+for conffile in $rm_conffile_files ; do
+    dpkg-maintscript-helper rm_conffile \
+        $conffile 5.5.4-3~ ltsp-client-core -- "$@"
+done
+
+#DEBHELPER#


live well,
  vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-ltsp-devel/attachments/20150209/87113bda/attachment.sig>