Bug#402132: lvm2 racey symlink creation

[Alasdair G Kergon]

On Fri, Dec 08, 2006 at 12:20:05PM +0000, Ian Jackson wrote:
> This means that even if the vg is and remains active throughout, there
> is a moment when the symlink is missing.  Any other program on the
> system which is referring to that lv may see this glitch and
> misbehave.
 
Yep - vgmknodes looks to do that:-(

> The patch below fixes this.  It now does this instead:
>     symlink to /dev/<vg>/<lv>..tmp

I suggest using a different temp name - one outside the LV namespace:
Someone might have an LV already called <lv>..tmp.

  lib/misc/lvm-string.c:validate_name()
  use a char outside a-zA-Z0-9._+-  or prefix with -

Alasdair
-- 
agk at redhat.com