Bug#294066: Pid file handling broken

[Tore Anderson]

tags 294066 +patch
quit

* Patrick Caulfield

> multipathd is started very early on in the boot process. often
> before /var is mounted. PID files go in /var/run and if that dir
> doesn't exist the PID file handling is even more (and dangerously so)
> broken.

  I see that you've backed out the patch that originally caused me to
 submit this bug, as multipathd now is started later in the boot
 process.  Simply running multipath early and defer multipathd startup
 until later was a good solution to that problem, by the way.

  However, the pid file handling is still broken, but this time it is
 the init script that is the problem.  It looks for the file
 "multipath-tools.pid", while it is actually called "multipathd.pid".

  Trivial patch included:

--- /etc/init.d/multipath-tools~        2006-02-11 13:58:34.000000000 +0100
+++ /etc/init.d/multipath-tools 2006-02-11 14:00:07.000000000 +0100
@@ -2,7 +2,7 @@
 
 PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
 DAEMON=/sbin/multipathd
-NAME=multipath-tools
+NAME=multipathd
 DESC="multipath daemon"
 
 test -x $DAEMON || exit 0
@@ -36,7 +36,7 @@
        echo "."
        ;;
   *)
-       N=/etc/init.d/$NAME
+       N=/etc/init.d/multipath-tools
        echo "Usage: $N {start|stop|restart|reload|force-reload}" >&2
        exit 1
        ;;


-- 
Tore Anderson