Bug#390243: Why I wasn't using pkg-config to for libdevmapper....

[Theodore Tso]

On Tue, Jan 01, 2008 at 01:17:21PM -0600, Eric Sandeen wrote:
> I've been meaning to ask, does this patch:
> 
> http://cvs.fedoraproject.org/viewcvs/rpms/e2fsprogs/devel/e2fsprogs-1.39-blkid-devmapper.patch?rev=1.2&view=markup
> 
> look like it should go upstream; I am really not very good at autotools,
> but I think this is a more generic way to find the devmapper libs -
> which are in /lib or /lib64 and not /usr/lib on RH systems...

The idea is reasonable, but ----

1) PKG_PROG_PKG_CONFIG isn't defined in aclocal.m4, and it isn't
defined in the default autoconf 2.61 macro libraries.  That can be
worked around, but....

2)  At least on Debian, devmapper has a buggy .pc file.  The problem is
that "pkg-config --static --libs devmapper" returns:

	-L/lib -ldevmapper -lselinux -lsepol

instead of:

	-pthread -L/lib -ldevmapper -lselinux -lsepol

The problem is that devmapper.pc needs to patched as follows:

--- /usr/lib/pkgconfig/devmapper.pc.orig        2007-09-24 11:29:27.000000000 -0400
+++ /usr/lib/pkgconfig/devmapper.pc     2008-01-01 18:55:37.000000000 -0500
@@ -8,4 +8,4 @@
 Version: "1.02.20 (2007-06-15)"
 Cflags: -I${includedir} 
 Libs: -L${libdir} -ldevmapper
-Libs.private: -lselinux -lsepol
+Requires.private: libselinux libsepol

Eric, can you confirm whether or not Fedora has this bug fixed?  Maybe
a confirmation will convince Debian to fix this bug that has been
ignored for the past 1 YEAR and 93 DAYS.  Also, maybe you can check to
see if this needs to fixed upstream?

					- Ted