Bug#470063: multipath-tools: Problem with LSB header in init.d script

[Petter Reinholdtsen]

Package:  multipath-tools
Version:  0.4.7-8
Severity: important
Tags:     patch
User:     initscripts-ng-devel at lists.alioth.debian.org
Usertags: incorrect-dependency

I just checked the shutdown order in unstable on a machine with
dependency based boot sequencing enabled, and discovered a problem
with the init.d scripts provided in multipath-tools.  It refuses to
install because of this problem.  The problem is that it have a hard
dependency on libdevmapper, which is not installed.  As this isn't a
dependency of the package, I believe it should be an optional
dependency.  To make sure the multipath-tools-boot have a well defined
location in the boot also when none of libdevmapper and
module-init-tools is installed, I suggest giving it a hard dependency
on checkroot.

Another issue is that the multipath-tools init.d script list S in its
stop runlevel list.  This make a useless stop symlink in rcS.d/.  It
should not be included.

Here is a patch to solve these issues.

diff -ur multipath-tools-0.4.8.orig/debian/multipath-tools.init multipath-tools-0.4.8/debian/multipath-tools.init
--- multipath-tools-0.4.8.orig/debian/multipath-tools.init      2008-03-08 23:09:03.000000000 +0100
+++ multipath-tools-0.4.8/debian/multipath-tools.init   2008-03-08 23:10:33.000000000 +0100
@@ -6,7 +6,7 @@
 # Should-Start:      iscsi
 # Should-Stop:       iscsi
 # Default-Start:     2 3 4 5
-# Default-Stop:      S 0 1 6
+# Default-Stop:      0 1 6
 # Short-Description: multipath daemon
 # Description:
 ### END INIT INFO
Only in multipath-tools-0.4.8/debian: multipath-tools.init.~1~
diff -ur multipath-tools-0.4.8.orig/debian/multipath-tools.multipath-tools-boot.init multipath-tools-0.4.8/debian/multipath-tools.multipath-tools-boot.init
--- multipath-tools-0.4.8.orig/debian/multipath-tools.multipath-tools-boot.init 2008-03-08 23:09:03.000000000 +0100
+++ multipath-tools-0.4.8/debian/multipath-tools.multipath-tools-boot.init      2008-03-08 23:14:08.000000000 +0100
@@ -1,10 +1,10 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          multipath-tools-boot
-# Required-Start:    libdevmapper module-init-tools
-# Required-Stop:     libdevmapper module-init-tools
-# Should-Start:      iscsi
-# Should-Stop:       iscsi
+# Required-Start:    checkroot
+# Required-Stop:     checkroot
+# Should-Start:      libdevmapper module-init-tools iscsi
+# Should-Stop:       libdevmapper module-init-tools iscsi
 # Default-Start:     S
 # Default-Stop:
 # Short-Description: early multipath boot script

Happy hacking,
--
Petter Reinholdtsen