Bug#542370: Should multipath-tools-boot depend on iscsi?

[Petter Reinholdtsen]

[Petter Reinholdtsen]
> This is the patch I used in the NMU I just uploaded.

Via piuparts did I discover that there are more problems with the
current headers.  The package fail to install if module-init-tools
isn't already installed, because the init.d script have a hard
dependency on a script providing module-init-tools, but the package do
not depend on any package with such script.  I believe the correct
approach is to make the module-init-tools dependency optional.
Further, I suspect the script should have an optional dependency on
udev too, to make sure drivers and /dev/ nodes are created before
multipath-tools-boot execute when concurrent booting is used.

Also, the multipath-tools should have a dependency on either $local_fs
or $remote_fs, and as far as I can see the script do not need files in
/usr/ and should thus depend on $local_fs.

Here is a patch to solve these issues.

diff -ur multipath-tools-0.4.8/debian/multipath-tools.init multipath-tools-0.4.8-pere/debian/multipath-tools.init
--- multipath-tools-0.4.8/debian/multipath-tools.init   2009-09-23 23:20:07.000000000 +0200
+++ multipath-tools-0.4.8-pere/debian/multipath-tools.init      2009-09-23 23:17:30.000000000 +0200
@@ -1,8 +1,8 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          multipath-tools
-# Required-Start:    udev $syslog
-# Required-Stop:     udev $syslog
+# Required-Start:    udev $local_fs $syslog
+# Required-Stop:     udev $local_fs $syslog
 # Should-Start:      iscsi
 # Should-Stop:       iscsi
 # Default-Start:     2 3 4 5
diff -ur multipath-tools-0.4.8/debian/multipath-tools.multipath-tools-boot.init multipath-tools-0.4.8-pere/debian/multipath-tools.multipath-tools-boot.init
--- multipath-tools-0.4.8/debian/multipath-tools.multipath-tools-boot.init      2009-09-23 23:20:07.000000000 +0200
+++ multipath-tools-0.4.8-pere/debian/multipath-tools.multipath-tools-boot.init 2009-09-23 23:18:09.000000000 +0200
@@ -1,8 +1,10 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:          multipath-tools-boot
-# Required-Start:    checkroot module-init-tools
-# Required-Stop:     checkroot module-init-tools
+# Required-Start:    checkroot
+# Required-Stop:     checkroot
+# Should-Start:      udev module-init-tools
+# Should-Stop:       udev module-init-tools
 # Default-Start:     S
 # Default-Stop:
 # Short-Description: early multipath boot script

Happy hacking,
-- 
Petter Reinholdtsen