Bug#719738: [PATCH] Please install the lvm2 systemd generator

[Michael Stapelberg]

Hi Bastian,

Replying to multiple mails at once:

Bastian Blank <waldi at debian.org> writes:
> There is no udev.service in the upstream systemd source. In the Debian
> package it is a symlink to systemd-udevd.service.
Yes, as you noticed, the upstream name is systemd-udevd.

> What upstream thinks is irrelevant if the system expecations are
> different. Why can't this be a symlink to systemd-udev-settle.service,
> which provides the backward compatible behaviour
I disagree. We should follow upstream unless there is a really compelling and
good technical reason not to. I don’t see any reason in our case.

Upstream considers software that needs “udevadm settle” (what you refer to with
systemd-udev-settle.service) as broken. In case there is really no other
solution, in the systemd world you can use Wants=systemd-udev-settle.service
together with After=systemd-udev-settle.service.

> Also please show me where the generator stuff is documented.
First google hit for “"systemd" generator” for me:
http://www.freedesktop.org/wiki/Software/systemd/Generators/

> > I don’t quite understand why you are hesitant to do that, given that
> > there are absolutely no changes to sysvinit users. Maybe you can clarify
> > what your concern is, if any?
> 
> Because it deliberately breaks stuff.
Nothing will be broken when shipping the generator as I asked you to. On the
contrary, this fixes booting for many people. Can you elaborate on what would
be broken?

Bastian Blank <waldi at debian.org> writes:
> The string udev.service does not show up in the upstream source, so you
> actually lied about this being something upstream does. This make it a
> deliberate and undocumented choice of the Debian maintainer to make this
> a symlink to systemd-udev.service and break backward compatibility.
The upstream name for udev.service changed to systemd-udev.service in commit
f13b388f97bc3ba8db844bd3413d510e2466a0b6, see
http://cgit.freedesktop.org/systemd/systemd/commit/?id=f13b388f97

The symlink that we ship in Debian is necessary because we still have sysvinit
scripts, whereas other distributions don’t need to care. This is why it lives
in the Debian package and not upstream.

My statement that we take systemd-udev.service directly from upstream still
stands and is true.

I did in fact not lie. The mere accusation of lying is something that makes me
angry and I don’t find it acceptable. This is really not the spirit in which we
want to work together in Debian. I request an apology from you.

> Because the shipped generator from RedHat does not fail gracefully, I
> consider doing this a different way
Can you please elaborate on what you mean by “does not fail gracefully”?

Have you opened an upstream bug about that? If so, where can I find it?

-- 
Best regards,
Michael