Bug#757508: multipath-tools: multipath segmentation Fault (libmultipath: update waiter handling)

[Rafael David Tinoco]

Package: multipath-tools
Version: 0.4.9-3
Severity: important
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu utopic ubuntu-patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

In Ubuntu, the attached patch was applied to achieve the following:

[Impact]

 * Multipath can cause segmentation fault due to wrong code and can
   possibly cause user to loose access to multipath devices.

[Test Case]

 * To use multipath and wait for the problem to occur sometime (inevitable).

[Regression Potential]

 * Patch 1/4 tries to fix the issue. Patch 2/4 fixes the 1/4.
 * Patch 3/4 discovers 1/4 was no good. Patch 4/4 fixes 3/4.

 * Fix based on upstream code (96f8146) + subsequent patches.
 * Followed this code development until the issue was addressed.

[Changelog]

  * Added 0001-libmultipath-update-waiter-handling.patch (LP: #1354114)
  * Added 0002-Race-condition-when-calling-stop_waiter_thread.patch (LP: #1354114)
  * Added 0003-multipath-clean-up-code-for-stopping-the-waiter-thre.patch (LP: #1354114)
  * Added 0004-Fix-race-condition-in-stop_waiter_thread.patch (LP: #1354114)

[Fix]

Fix from upstream: 

The current 'waiter' structure accesses fields which belong
to the main 'mpp' structure, which has a totally different
lifetime.

Thanks for considering the patch.

- -- System Information:
Debian Release: jessie/sid
  APT prefers utopic-updates
  APT policy: (500, 'utopic-updates'), (500, 'utopic')
Architecture: amd64 (x86_64)

Kernel: Linux 3.13.0-32-generic (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4

iQEcBAEBCgAGBQJT5SnYAAoJEAynk4KHaD/Az18IAK4yUZn8kUq69+53RiohAqoV
T2BNxVqfVGa5nWFKhDmETU3xuJZVHJFUxUdcr+JlByvd5yJdIOThVc5c3vlvaZW2
HOejXtcnqei3JEQZPmvSQ2esMfF+HANtkiMTookAL+uPDkSX9NYSnFyqzztyCGhg
Q8cGJRS3dfsO0siCN1ellc/DFv0ojW+7c+p8hN5J5++qQ7nu+7KY29oUC7ifn7wm
D+njXSZvtj3URskCIEn1eDGIfXEsAgThbVr3djeZJ0ZzMdCLat6mZ6cfwJ6rv4V6
nFE7DoIqu7YrJazOFoP0IFUg9IO0Ve+5eOLAZ8DFdykeoTgEFL8CRLcXbW7jHc0=
=neMH
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: multipath-tools_0.4.9-3ubuntu9.debdiff
Type: text/x-diff
Size: 22853 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-lvm-maintainers/attachments/20140808/bb9c2318/attachment.diff>