Bug#739043: lvm2: Please use --no-enable option instead of patching lvm2-lvmetad.service file

[Laurent Bigonville]

Le Sat, 1 Mar 2014 10:31:48 +0100,
Bastian Blank <waldi at debian.org> a écrit :

> On Sat, Feb 15, 2014 at 12:11:46PM +0100, Laurent Bigonville wrote:
> > Severity: important
> 
> This needs something to actually be broken. Please be specific and
> show outcome.

Well I can definitely return you the question, what are you trying to
fix here? Why are you patching upstream files instead of using debian
provided options or diverting from upstream in general?

> 
> > -[Install]
> > -WantedBy=sysinit.target
> > IMHO this would breaks the ordering if somebody wants to explicitly
> > enable the service.
> 
> No. The ordering is done by After and Before, never by Wants. That it
> is already broken is a different problem.

Well the word "ordering" is maybe wrong, but still if you want your
service to be running when the sysinit.target target is started, the
WantedBy is needed. Why are you preventing people that wants to enable
the service instead of depending on the activation to do so?

Anyway this is indeed probably a minor issue, and this bug should maybe
be converted in "Please complete systemd integration" or something like
that, because looking at the installed files, it seems that a bunch
of .service files are not installed. Did you discuss this with the
systemd maintainers?

dh_install: lib/systemd/system/blk-availability.service exists in debian/build/install_deb but is not installed to anywhere
dh_install: lib/systemd/system/lvm2-pvscan at .service exists in debian/build/install_deb but is not installed to anywhere
dh_install: lib/systemd/system/dm-event.socket exists in debian/build/install_deb but is not installed to anywhere
dh_install: lib/systemd/system/dm-event.service exists in debian/build/install_deb but is not installed to anywhere
dh_install: lib/systemd/system/lvm2-monitor.service exists in debian/build/install_deb but is not installed to anywhere

Laurent