Bug#760682: lvm2: debian/rules try to restart lvm2-monitor.socket which doesn't exist

[Laurent Bigonville]

Le Thu, 11 Sep 2014 23:30:24 +0200,
Bastian Blank <waldi at debian.org> a écrit :

> Control: severity -1 important
> 
> On Sat, Sep 06, 2014 at 09:21:01PM +0200, Laurent Bigonville wrote:
> > This is causing issues as the maintainer script are trying to
> > start/stop it:
> 
> Please show _what_ issues it produces.  Sure it is not right, but you
> forgot to show that it actually makes the package unusable.  I tried
> re-installing it several times and it did not break.

lvm2.prerm is containing the following code:

# Automatically added by dh_systemd_start
if [ -d /run/systemd/system ]; then
        deb-systemd-invoke stop lvm2-monitor.socket >/dev/null
fi
# End automatically added section

On a machine running systemd (214), the following code is returning !=
0:

root at fornost:~# deb-systemd-invoke stop lvm2-monitor.socket >/dev/null ; echo $?
Failed to stop lvm2-monitor.socket: Unit lvm2-monitor.socket not loaded.
5

The fact that some piece of code is returning non-zero in the prerm
script means that removing/updating/purging the pkg will just fail for
people running systemd.

This looks RC to me (breaking maintainer script is not nice for the
users).

root at fornost:~# dpkg -i /tmp/lvm2_2.02.111-1_amd64.deb 
dpkg : avertissement : dégradation (« downgrade ») de lvm2 depuis 2.02.111-1bigon1 vers 2.02.111-1
(Lecture de la base de données... 275997 fichiers et répertoires déjà installés.)
Préparation du dépaquetage de /tmp/lvm2_2.02.111-1_amd64.deb ...
Dépaquetage de lvm2 (2.02.111-1) sur (2.02.111-1bigon1) ...
Paramétrage de lvm2 (2.02.111-1) ...
update-initramfs: deferring update (trigger activated)
Failed to start lvm2-monitor.socket: Unit lvm2-monitor.socket failed to load: No such file or directory.
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
Traitement des actions différées (« triggers ») pour man-db (2.6.7.1-1) ...
Traitement des actions différées (« triggers ») pour initramfs-tools (0.116) ...
update-initramfs: Generating /boot/initrd.img-3.16-1-amd64
W: mdadm: /etc/mdadm/mdadm.conf defines no arrays.
W: mdadm: no arrays defined in configuration file.

Reinstalling the pkg a 2nd time:

root at fornost:~# dpkg -i /tmp/lvm2_2.02.111-1_amd64.deb 
(Lecture de la base de données... 275993 fichiers et répertoires déjà installés.)
Préparation du dépaquetage de /tmp/lvm2_2.02.111-1_amd64.deb ...
Failed to stop lvm2-monitor.socket: Unit lvm2-monitor.socket not loaded.
dpkg : avertissement : le sous-processus ancien script pre-removal a retourné une erreur de sortie d'état 5
dpkg: tentative d'exécution du script du nouveau paquet à la place...
Failed to stop lvm2-monitor.socket: Unit lvm2-monitor.socket not loaded.
dpkg: erreur de traitement de l'archive /tmp/lvm2_2.02.111-1_amd64.deb (--install) :
 le sous-processus nouveau script pre-removal a retourné une erreur de sortie d'état 5
Failed to start lvm2-monitor.socket: Unit lvm2-monitor.socket failed to load: No such file or directory.
update-rc.d: warning: start and stop actions are no longer supported; falling back to defaults
Des erreurs ont été rencontrées pendant l'exécution :
 /tmp/lvm2_2.02.111-1_amd64.deb


Could you please prevent lvm to migrate to testing to not break futur
upgrades and removal of this packages for jessie users?

The next question is why the start counterpart is not returning
non-zero, but that a question for deb-systemd-invoke maintainers I
guess.