Bug#782400: multipath-tools: libmultipath: fix discovery of devices with empty rev sysfs attribute

Ritesh Raj Sarraf rrs at researchut.com
Thu May 28 06:51:33 UTC 2015


On Thursday 28 May 2015 12:37 AM, Mauricio Faria de Oliveira wrote:
> Thanks!
> Do you think it would be a problem to include the patch?
>
> As explained the commit message, I think it's an obvious fix for the
> regression introduced (with 'chomp', or similar name) for the case
> when the sysfs attribute 'rev' contains only spaces -- because the
> 'chomp' (or similarly named) function will remove all spaces from the
> string, so its size will be zero (so, the check for size greater than,
> but not 'or equal to', will surely fail).

No. It has nothing to do with the patch.

These days I don't work on storage, i.e. don't have a team that spends
the time on these tools. So I keep the upstream first policy, for now.
Even my patch (kpartx) is very trivial but 've put it on hold until
Christoph accepts it.

If this really doesn't work in the long run, we may re-visit it.

-- 
Ritesh Raj Sarraf
RESEARCHUT - http://www.researchut.com
"Necessity is the mother of invention."


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-lvm-maintainers/attachments/20150528/44d1d8c1/attachment-0001.sig>


More information about the pkg-lvm-maintainers mailing list