Bug#570232: Please ship cmirrord

Ferenc Wágner wferi at niif.hu
Tue Nov 22 12:40:49 UTC 2016


Hi Bastian,

Please ship cmirrord in some form.  Including it in the clvm package
(not that I advocate it) is as simple as:

diff --git a/debian/clvm.install b/debian/clvm.install
index 03a22a5..3ec28dd 100644
--- a/debian/clvm.install
+++ b/debian/clvm.install
@@ -1,5 +1,8 @@
 lib/systemd/lvm2-cluster*
 lib/systemd/system/lvm2-cluster*
 lib/systemd/system/lvm2-clvmd*
+lib/systemd/system/lvm2-cmirrord*
 usr/sbin/clvmd
+usr/sbin/cmirrord
 usr/share/man/man8/clvmd*
+usr/share/man/man8/cmirrord*
diff --git a/debian/rules b/debian/rules
index 68c6f45..f4e16c4 100755
--- a/debian/rules
+++ b/debian/rules
@@ -89,6 +89,7 @@ $(STAMPS_DIR)/setup_deb: $(STAMPS_DIR)/source
                --enable-applib \
                --enable-blkid_wiping \
                --enable-cmdlib \
+               --enable-cmirrord \
                --enable-dmeventd \
                --enable-lvmetad \
                --enable-lvmpolld \

The complication lies with the boot process integration, which is
already problematic for clvmd, because corosync has DefaultDependencies
(it lives under /usr) but clvmd orders before remote-fs-pre.target.
Fortunately clvmd has no [Install] section, but the upstream cmirror
service file has.  How does all this fit together?  If it does not, I'd
vote for simply omitting (or disarming) the services files.  Shipping
the daemon leaves the user with a possibility at least, and adding
service files in local configuration is easy.  Some may not even want
service files, but rather manage these daemons via a resource manager
(like Pacemaker).  What do you think?

As a side note, you might also want to

diff --git a/debian/clvm.maintscript b/debian/clvm.maintscript
new file mode 100644
index 0000000..22915e3
--- /dev/null
+++ b/debian/clvm.maintscript
@@ -0,0 +1 @@
+rm_conffile /etc/init.d/clvm 2.02.164-1~
-- 
Regards,
Feri



More information about the pkg-lvm-maintainers mailing list