Bug#865463: lvm2: VG with thin pool LV can be created without thin-provisioning-tools

[Andreas Hasenack]

Package: lvm2
Version: 2.02.168-2
Severity: normal

Dear Maintainer,

Creating a thin pool LV is allowed even when thin-provisioning-tools is not
installed. But deactivating or activating that VG fails. Since deactivating
the VG usually only happens at reboot, the user might fail to notice this
big problem until then.

Maybe the lvconvert tool, used to combine the two "thin LVs" into a thin
pool LV, should refuse to run if thin-provisioning-tools, or the needed
scripts, aren't installed.

root at debian:~# pvcreate /dev/vda1
  Physical volume "/dev/vda1" successfully created.

root at debian:~# vgcreate vg /dev/vda1
  Volume group "vg" successfully created

root at debian:~# lvcreate -n pool0 -l 90%VG vg
  Logical volume "pool0" created.

root at debian:~#  lvcreate -n pool0meta -l 5%VG vg
  Logical volume "pool0meta" created.

root at debian:~# lvconvert --type thin-pool --poolmetadata vg/pool0meta
vg/pool0
  WARNING: Converting logical volume vg/pool0 and vg/pool0meta to thin
pool's data and metadata volumes with metadata wiping.
  THIS WILL DESTROY CONTENT OF LOGICAL VOLUME (filesystem etc.)
Do you really want to convert vg/pool0 and vg/pool0meta? [y/n]: y
  Converted vg/pool0 to thin pool.

root at debian:~# l /dev/mapper/
total 0
drwxr-xr-x  2 root root     120 Jun 21 14:15 .
drwxr-xr-x 20 root root    3.1K Jun 21 14:15 ..
crw-------  1 root root 10, 236 Jun 21 14:15 control
lrwxrwxrwx  1 root root       7 Jun 21 14:15 vg-pool0 -> ../dm-2
lrwxrwxrwx  1 root root       7 Jun 21 14:15 vg-pool0_tdata -> ../dm-1
lrwxrwxrwx  1 root root       7 Jun 21 14:15 vg-pool0_tmeta -> ../dm-0

root at debian:~# vgchange -a n
  /usr/sbin/thin_check: execvp failed: No such file or directory
  WARNING: Integrity check of metadata for pool vg/pool0 failed.
  0 logical volume(s) in volume group "vg" now active

root at debian:~# vgchange -a y
  /usr/sbin/thin_check: execvp failed: No such file or directory
  Check of pool vg/pool0 failed (status:2). Manual repair required!
  0 logical volume(s) in volume group "vg" now active

root at debian:~# l /dev/mapper
total 0
drwxr-xr-x  2 root root      60 Jun 21 14:15 .
drwxr-xr-x 19 root root    3.0K Jun 21 14:15 ..
crw-------  1 root root 10, 236 Jun 21 14:15 control

Can't get them back now, unless I install thin-provisioning-tools.

-- System Information:
Debian Release: 9.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-3-amd64 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages lvm2 depends on:
ii  dmeventd                  2:1.02.137-2
ii  dmsetup                   2:1.02.137-2
ii  init-system-helpers       1.48
ii  libblkid1                 2.29.2-1
ii  libc6                     2.24-11+deb9u1
ii  libdevmapper-event1.02.1  2:1.02.137-2
ii  libdevmapper1.02.1        2:1.02.137-2
ii  liblvm2app2.2             2.02.168-2
ii  libreadline5              5.2+dfsg-3+b1
ii  libudev1                  232-25
ii  lsb-base                  9.20161125

lvm2 recommends no packages.

Versions of packages lvm2 suggests:
pn  thin-provisioning-tools  <none>

-- no debconf information
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-lvm-maintainers/attachments/20170621/21915169/attachment.html>