Bug#858456: Stale references to 60-multipath.rules and 60-kpartx.rules

[Christian Ehrhardt]

Package: multipath-tools
Version: 0.6.4-4
Severity: normal

Hi,
we got an Ubuntu bug report [1] , but I think this is better solved in
Debian than to make our Delta even more weird, therefore reporting to you
here.

The TL;DR is that I think the 60-multipath.rules references in
debian/initramfs/hooks no more apply - so they should be either fixed or
dropped.
Since it seems to work without dropping likely is better, but I'm not sure
on this.

This is the list of references I still find:
- In postinst is only a transition to remove "Removing dangling $RULE
symlink..."
  The same it true for the kpartx.rule (That transition should be done now
right?)
- multipath/Makefile installs it with different names now 56-multipath.rules
- debian/initramfs/hooks refers to older filenames (60-multipath.rules),
therefore current references are no-ops.

One can search e.g. buildlogs to confirm the file no more existing: [2]
Or look on a Debian system with all multipath packages installed which shows
  $ dpkg -L kpartx multipath-tools multipath-tools-boot | egrep '\.rules'
  /lib/udev/rules.d/60-kpartx.rules

I must admit I don't see how the 60-kpartx.rules gets to its name (I'd have
expected 66-), but it is there so I'm not complaining on that one.

Yet on the no more existing rules there could be two changes made
1. drop the multipath.rules references like
"0001-stale-60-multipath.rules-ref.patch"
2. If you agree that the transition of the old rule references is done (was
debian/lenny 0.4.8-13 might be even older), then also drop the link dropper
code like in "0002-postinst-simplify-by-dropping-old-transition.patch"
On the latter one might even consider dropping the full case statement now.

Both patches are attached.
Open for discussion, if you want changes as real commits somewhere let me
know.

[1]: https://bugs.launchpad.net/ubuntu/+source/multipath-tools/+bug/1548303
[2]:
https://buildd.debian.org/status/fetch.php?pkg=multipath-tools&arch=i386&ver=0.6.4-4&stamp=1487750289&raw=0

-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-lvm-maintainers/attachments/20170322/e7353a01/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-stale-60-multipath.rules-ref.patch
Type: text/x-patch
Size: 798 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-lvm-maintainers/attachments/20170322/e7353a01/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-postinst-simplify-by-dropping-old-transition.patch
Type: text/x-patch
Size: 1902 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-lvm-maintainers/attachments/20170322/e7353a01/attachment-0001.bin>